sentry-react-native icon indicating copy to clipboard operation
sentry-react-native copied to clipboard

fix(internal): Remove deprecated JS SDK code

Open krystofwoldrich opened this issue 1 year ago • 5 comments

:loudspeaker: Type of change

  • [ ] Bugfix
  • [ ] New feature
  • [ ] Enhancement
  • [ ] Refactoring

:scroll: Description

:bulb: Motivation and Context

:green_heart: How did you test it?

:pencil: Checklist

  • [ ] I reviewed submitted code
  • [ ] I added tests to verify changes
  • [ ] No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • [ ] All tests passing
  • [ ] No breaking changes

:crystal_ball: Next steps

krystofwoldrich avatar Feb 02 '24 18:02 krystofwoldrich

Fails
:no_entry_sign: Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Remove deprecated JS SDK code ([#3576](https://github.com/getsentry/sentry-react-native/pull/3576))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by :no_entry_sign: dangerJS against 0c0157541f19b7e042737ca3363c5c51dfc78b3a

github-actions[bot] avatar Feb 02 '24 18:02 github-actions[bot]

Android (legacy) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 475.36 ms 502.56 ms 27.20 ms
Size 17.73 MiB 19.93 MiB 2.20 MiB

Previous results on branch: kw-fix-deprecations

Startup times

Revision Plain With Sentry Diff
56d9dcc27e24a3d8ec9c054690a695ac6edf7549 407.08 ms 438.22 ms 31.14 ms

App size

Revision Plain With Sentry Diff
56d9dcc27e24a3d8ec9c054690a695ac6edf7549 17.73 MiB 19.90 MiB 2.17 MiB

github-actions[bot] avatar Feb 02 '24 18:02 github-actions[bot]

iOS (legacy) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1202.57 ms 1203.63 ms 1.06 ms
Size 2.36 MiB 2.92 MiB 569.53 KiB

Previous results on branch: kw-fix-deprecations

Startup times

Revision Plain With Sentry Diff
56d9dcc27e24a3d8ec9c054690a695ac6edf7549+dirty 1241.27 ms 1246.61 ms 5.35 ms

App size

Revision Plain With Sentry Diff
56d9dcc27e24a3d8ec9c054690a695ac6edf7549+dirty 2.36 MiB 2.90 MiB 552.83 KiB

github-actions[bot] avatar Feb 02 '24 19:02 github-actions[bot]

iOS (new) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1235.91 ms 1242.73 ms 6.82 ms
Size 2.92 MiB 3.48 MiB 575.08 KiB

Previous results on branch: kw-fix-deprecations

Startup times

Revision Plain With Sentry Diff
56d9dcc27e24a3d8ec9c054690a695ac6edf7549+dirty 1236.80 ms 1237.98 ms 1.17 ms

App size

Revision Plain With Sentry Diff
56d9dcc27e24a3d8ec9c054690a695ac6edf7549+dirty 2.92 MiB 3.46 MiB 557.25 KiB

github-actions[bot] avatar Feb 02 '24 19:02 github-actions[bot]

Android (new) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 367.77 ms 409.09 ms 41.32 ms
Size 7.15 MiB 8.20 MiB 1.06 MiB

Previous results on branch: kw-fix-deprecations

Startup times

Revision Plain With Sentry Diff
56d9dcc27e24a3d8ec9c054690a695ac6edf7549+dirty 340.87 ms 374.77 ms 33.90 ms

App size

Revision Plain With Sentry Diff
56d9dcc27e24a3d8ec9c054690a695ac6edf7549+dirty 7.15 MiB 8.18 MiB 1.03 MiB

github-actions[bot] avatar Feb 05 '24 16:02 github-actions[bot]