sentry-react-native icon indicating copy to clipboard operation
sentry-react-native copied to clipboard

Should invalid integrations transaction be recorded as dropped or discarded silently?

Open krystofwoldrich opened this issue 2 years ago • 2 comments

Description

Currently, transactions discarded by our integrations are being recorded as client dropped because of sampling_rate even when the sampling rate is set to 1.

How transaction.sampled = false is used in RN SDK.

client.recordDroppedEvent('event_processor', 'transaction') better reflects the reason.

This will likely require extra property on the Transaction class that will be handled onFinish the same as sampled

krystofwoldrich avatar May 17 '23 09:05 krystofwoldrich

Should we send this information at all? List all the cases where the integrations set sampled = false.

krystofwoldrich avatar May 19 '23 12:05 krystofwoldrich

@krystofwoldrich as this recently came up, I think we should decide and prioritize this

kahest avatar Mar 12 '25 08:03 kahest