sentry-react-native icon indicating copy to clipboard operation
sentry-react-native copied to clipboard

Replace `sdkInfo` on iOS

Open krystofwoldrich opened this issue 3 years ago • 5 comments

Description

https://github.com/getsentry/sentry-react-native/blob/86821a42777cb1819de312df6cac058f5224b1af/ios/RNSentry.m#L158-L161

sdkInfo is deprecated https://github.com/getsentry/sentry-cocoa/pull/1960

PrivateSentrySDKOnly.getSdkName and PrivateSentrySDKOnly.getSdkVersionString to retrieve the information

Cocoa issue

krystofwoldrich avatar Oct 10 '22 07:10 krystofwoldrich

Instead of this:

resolve(@{ 
     @"name": sentryOptions.sdkInfo.name, 
     @"version": sentryOptions.sdkInfo.version 
         }); 

do this

resolve(@{ 
     @"name": PrivateSentrySDKOnly.getSdkName, 
     @"version": PrivateSentrySDKOnly.getSdkVersionString 
         }); 

brustolin avatar Oct 10 '22 08:10 brustolin

@brustolin that's possible but still not possible to add a new package. https://github.com/getsentry/sentry-dart/issues/1056#issuecomment-1272970663

marandaneto avatar Oct 10 '22 08:10 marandaneto

on RN iOS, the new package is added on the JS layer. https://github.com/getsentry/sentry-react-native/blob/86821a42777cb1819de312df6cac058f5224b1af/src/js/integrations/sdkinfo.ts#L54-L61 via _nativeSdkInfo that is fetch from fetchNativeSdkInfo So this is possible with the https://github.com/getsentry/sentry-react-native/issues/2530#issuecomment-1272964146 alternative.

marandaneto avatar Oct 10 '22 08:10 marandaneto

Can we close this?

brustolin avatar Oct 12 '22 13:10 brustolin

Can we close this?

This is not fixed yet, why would we close it?

marandaneto avatar Oct 13 '22 07:10 marandaneto

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Nov 04 '22 00:11 github-actions[bot]