sentry-react-native icon indicating copy to clipboard operation
sentry-react-native copied to clipboard

Allow CLI failures (e.g. server connecting issues in build time)

Open n-kulic opened this issue 2 years ago • 1 comments

OS:

  • [ ] Windows
  • [x] MacOS
  • [ ] Linux

Platform:

  • [x] iOS
  • [ ] Android

SDK:

  • [x] @sentry/react-native (>= 2.4.0)
  • [ ] react-native-sentry (<= 0.43.2)

SDK version: 2.4.0

react-native version: 0.63.4

Are you using Expo?

  • [ ] Yes
  • [x] No

Are you using sentry.io or on-premise?

  • [ ] sentry.io (SaaS)
  • [x] on-premise

Configuration:

(@sentry/react-native)

Sentry.init({
    dsn: SENTRY_DSN,
    environment: 'dev'
})

I have following issue:

In IOS build process it happens that a request is made to our Sentry server, and if Sentry server is temporary down (in our case it happens often), an error throws:

-error: API request failed
  caused by: sentry reported an error: gateway timeout (http status: 504)
Add --log-level=[info|debug] or export SENTRY_LOG_LEVEL=[info|debug] to see more output.

I would like to allow CLI failure because it currently makes CI/CD pipeline to fail. In @sentry/webpack-plugin there is an option to override default error handler and allow CLI failure, is there a similar option in @sentry/react-native as well? * source: https://github.com/getsentry/sentry-webpack-plugin#options (errorHandler)

Steps to reproduce:

  • Add Sentry to newly created app and initialize it Sentry.init(..)
  • Close/stop Sentry server
  • Try to build IOS project

Actual result:

Build fails because Sentry server isn't responsive.

Expected result:

Allow CLI failures as in case when there are issues connecting to Sentry server (5xx error)

n-kulic avatar Aug 07 '22 21:08 n-kulic

Same issue here.

nurycaroline avatar Aug 11 '22 22:08 nurycaroline

We are already tracking this issue here, thanks for raising it.

marandaneto avatar Aug 16 '22 13:08 marandaneto