sentry-react-native icon indicating copy to clipboard operation
sentry-react-native copied to clipboard
verified publisher icon getsentry

v5.0.0 release

Open marandaneto opened this issue 3 years ago • 3 comments

PR for v5.0.0

#skip-changelog

marandaneto avatar Jul 22 '22 11:07 marandaneto

I've tried RN 0.70 with the latest alpha release and everything seems to be working.

To my surprise activating the new TurboModules didn't break the build. I haven't find anywhere if you can mix NativeModules and TurboModules, but it would make sense that you can otherwise the transition to the new architecture would be too painful.

I also tried the new Fabric renderer and errors being reported as expected.

krystofwoldrich avatar Sep 08 '22 11:09 krystofwoldrich

Outdated

Android Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 440.54 ms 454.76 ms 14.22 ms
Size 17.73 MiB 19.95 MiB 2.21 MiB

Previous results on branch: 5.0.0

Startup times

Revision Plain With Sentry Diff
1499093aac555e668d197e30fdec2eda165e1a5a 358.87 ms 363.25 ms 4.37 ms
b4d768bc1821941108e5014a21799b3dcde649a9 316.47 ms 334.06 ms 17.59 ms
2a133c260043113e703d8b6aa156ccab3e4b335a 336.00 ms 341.78 ms 5.78 ms
70013c74bd0fed33fa79820077940997ef719c71 344.17 ms 358.76 ms 14.59 ms
b9ac2e8db0b920a5aef282f848afabc59521696d 314.22 ms 321.52 ms 7.30 ms
f669ecf46c035545f8f9734c9fed3a0dc54e773d 314.46 ms 317.86 ms 3.40 ms
17717b8f7a3a043315f0db36dbad34b191ae346e 315.32 ms 329.42 ms 14.10 ms
885862fd654bc7b8bf0d0d27712c2c2aa36f2745 335.92 ms 340.49 ms 4.57 ms
54885628c9d4374cf664a87f4b3477ca774f20a2+dirty 336.55 ms 353.17 ms 16.61 ms
3dd1a5bce6a00c1822ab354243342f03cada4131 337.06 ms 344.50 ms 7.44 ms

App size

Revision Plain With Sentry Diff
1499093aac555e668d197e30fdec2eda165e1a5a 25.82 MiB 27.83 MiB 2.01 MiB
b4d768bc1821941108e5014a21799b3dcde649a9 25.82 MiB 27.86 MiB 2.04 MiB
2a133c260043113e703d8b6aa156ccab3e4b335a 25.82 MiB 27.86 MiB 2.04 MiB
70013c74bd0fed33fa79820077940997ef719c71 25.82 MiB 27.83 MiB 2.01 MiB
b9ac2e8db0b920a5aef282f848afabc59521696d 25.82 MiB 27.83 MiB 2.01 MiB
f669ecf46c035545f8f9734c9fed3a0dc54e773d 25.82 MiB 27.83 MiB 2.01 MiB
17717b8f7a3a043315f0db36dbad34b191ae346e 25.82 MiB 27.86 MiB 2.04 MiB
885862fd654bc7b8bf0d0d27712c2c2aa36f2745 25.82 MiB 27.83 MiB 2.01 MiB
54885628c9d4374cf664a87f4b3477ca774f20a2+dirty 17.73 MiB 19.95 MiB 2.21 MiB
3dd1a5bce6a00c1822ab354243342f03cada4131 25.82 MiB 27.83 MiB 2.01 MiB

github-actions[bot] avatar Sep 26 '22 08:09 github-actions[bot]

iOS Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1234.16 ms 1249.84 ms 15.68 ms
Size 2.45 MiB 2.83 MiB 381.97 KiB

Previous results on branch: 5.0.0

Startup times

Revision Plain With Sentry Diff
f669ecf46c035545f8f9734c9fed3a0dc54e773d 1245.06 ms 1274.41 ms 29.35 ms
17717b8f7a3a043315f0db36dbad34b191ae346e 1264.14 ms 1269.94 ms 5.80 ms
885862fd654bc7b8bf0d0d27712c2c2aa36f2745 1241.58 ms 1252.96 ms 11.38 ms
b9ac2e8db0b920a5aef282f848afabc59521696d 1229.71 ms 1249.82 ms 20.11 ms
1499093aac555e668d197e30fdec2eda165e1a5a 1268.78 ms 1287.38 ms 18.60 ms
2a133c260043113e703d8b6aa156ccab3e4b335a 1232.78 ms 1238.56 ms 5.78 ms
70013c74bd0fed33fa79820077940997ef719c71 1237.84 ms 1258.46 ms 20.62 ms
b4d768bc1821941108e5014a21799b3dcde649a9 1236.63 ms 1257.16 ms 20.53 ms
cc863df652cd688a48fd2ca6df5b698865e2e170 1256.06 ms 1263.54 ms 7.48 ms
7bc07994786f11055e81598ef64c3079704c772e+dirty 1283.04 ms 1290.76 ms 7.72 ms

App size

Revision Plain With Sentry Diff
f669ecf46c035545f8f9734c9fed3a0dc54e773d 1.08 MiB 1.45 MiB 376.28 KiB
17717b8f7a3a043315f0db36dbad34b191ae346e 1.08 MiB 1.44 MiB 363.17 KiB
885862fd654bc7b8bf0d0d27712c2c2aa36f2745 1.08 MiB 1.45 MiB 376.28 KiB
b9ac2e8db0b920a5aef282f848afabc59521696d 1.08 MiB 1.45 MiB 376.28 KiB
1499093aac555e668d197e30fdec2eda165e1a5a 1.08 MiB 1.45 MiB 376.28 KiB
2a133c260043113e703d8b6aa156ccab3e4b335a 1.08 MiB 1.44 MiB 370.49 KiB
70013c74bd0fed33fa79820077940997ef719c71 1.08 MiB 1.44 MiB 371.41 KiB
b4d768bc1821941108e5014a21799b3dcde649a9 1.08 MiB 1.44 MiB 370.50 KiB
cc863df652cd688a48fd2ca6df5b698865e2e170 1.08 MiB 1.44 MiB 371.41 KiB
7bc07994786f11055e81598ef64c3079704c772e+dirty 2.45 MiB 2.83 MiB 381.11 KiB

github-actions[bot] avatar Sep 26 '22 09:09 github-actions[bot]

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Nov 18 '22 00:11 github-actions[bot]

The perf ios test is failing because of the cocoa pods codesigning from Xcode 14

  • https://github.com/facebook/react-native/issues/34673 (fixed in0.70.3 bur perf metrics are at 0.69.x at the moment)

krystofwoldrich avatar Nov 25 '22 13:11 krystofwoldrich

iOS (legacy) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1289.08 ms 1299.51 ms 10.43 ms
Size 2.36 MiB 2.82 MiB 462.76 KiB

Previous results on branch: 5.0.0

Startup times

Revision Plain With Sentry Diff
d760caf1e2cc34c23ee063cc2a238073a802b99e+dirty 1266.80 ms 1290.92 ms 24.12 ms
b868b539c3533fede4a02dae8c2246ffa3dd5a8c+dirty 1274.90 ms 1305.68 ms 30.78 ms
d0912399fb99550cb61670c1957ca90079d4ca38+dirty 1251.49 ms 1276.75 ms 25.26 ms
58ae9301bc42b3eb99e6d9d74079d2db048a4a6a+dirty 1274.36 ms 1296.42 ms 22.06 ms
34dc25964442b05d4ae800980dc4be60660ed483+dirty 1222.19 ms 1243.30 ms 21.11 ms

App size

Revision Plain With Sentry Diff
d760caf1e2cc34c23ee063cc2a238073a802b99e+dirty 2.36 MiB 2.81 MiB 462.03 KiB
b868b539c3533fede4a02dae8c2246ffa3dd5a8c+dirty 2.36 MiB 2.74 MiB 384.64 KiB
d0912399fb99550cb61670c1957ca90079d4ca38+dirty 2.36 MiB 2.74 MiB 384.64 KiB
58ae9301bc42b3eb99e6d9d74079d2db048a4a6a+dirty 2.36 MiB 2.82 MiB 462.49 KiB
34dc25964442b05d4ae800980dc4be60660ed483+dirty 2.36 MiB 2.82 MiB 462.46 KiB

github-actions[bot] avatar Dec 09 '22 13:12 github-actions[bot]

Android (new) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 326.74 ms 342.96 ms 16.21 ms
Size 7.15 MiB 8.09 MiB 962.72 KiB

Previous results on branch: 5.0.0

Startup times

Revision Plain With Sentry Diff
d760caf1e2cc34c23ee063cc2a238073a802b99e+dirty 270.61 ms 292.10 ms 21.49 ms
b868b539c3533fede4a02dae8c2246ffa3dd5a8c+dirty 321.42 ms 342.74 ms 21.32 ms
d0912399fb99550cb61670c1957ca90079d4ca38+dirty 340.16 ms 366.42 ms 26.26 ms
58ae9301bc42b3eb99e6d9d74079d2db048a4a6a+dirty 332.17 ms 349.92 ms 17.75 ms
34dc25964442b05d4ae800980dc4be60660ed483+dirty 355.90 ms 379.08 ms 23.19 ms

App size

Revision Plain With Sentry Diff
d760caf1e2cc34c23ee063cc2a238073a802b99e+dirty 7.15 MiB 8.08 MiB 956.12 KiB
b868b539c3533fede4a02dae8c2246ffa3dd5a8c+dirty 7.15 MiB 8.00 MiB 874.27 KiB
d0912399fb99550cb61670c1957ca90079d4ca38+dirty 7.15 MiB 8.00 MiB 874.38 KiB
58ae9301bc42b3eb99e6d9d74079d2db048a4a6a+dirty 7.15 MiB 8.08 MiB 959.23 KiB
34dc25964442b05d4ae800980dc4be60660ed483+dirty 7.15 MiB 8.08 MiB 959.22 KiB

github-actions[bot] avatar Dec 09 '22 14:12 github-actions[bot]

Android (legacy) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 329.78 ms 345.74 ms 15.96 ms
Size 17.73 MiB 20.04 MiB 2.31 MiB

Previous results on branch: 5.0.0

Startup times

Revision Plain With Sentry Diff
d760caf1e2cc34c23ee063cc2a238073a802b99e+dirty 367.76 ms 388.06 ms 20.30 ms
b868b539c3533fede4a02dae8c2246ffa3dd5a8c+dirty 339.52 ms 369.84 ms 30.32 ms
d0912399fb99550cb61670c1957ca90079d4ca38+dirty 425.61 ms 447.11 ms 21.50 ms
58ae9301bc42b3eb99e6d9d74079d2db048a4a6a+dirty 323.19 ms 339.14 ms 15.95 ms
34dc25964442b05d4ae800980dc4be60660ed483+dirty 370.55 ms 371.53 ms 0.98 ms

App size

Revision Plain With Sentry Diff
d760caf1e2cc34c23ee063cc2a238073a802b99e+dirty 17.73 MiB 20.03 MiB 2.30 MiB
b868b539c3533fede4a02dae8c2246ffa3dd5a8c+dirty 17.73 MiB 19.95 MiB 2.22 MiB
d0912399fb99550cb61670c1957ca90079d4ca38+dirty 17.73 MiB 19.95 MiB 2.22 MiB
58ae9301bc42b3eb99e6d9d74079d2db048a4a6a+dirty 17.73 MiB 20.04 MiB 2.30 MiB
34dc25964442b05d4ae800980dc4be60660ed483+dirty 17.73 MiB 20.04 MiB 2.30 MiB

github-actions[bot] avatar Dec 14 '22 10:12 github-actions[bot]

iOS (new) Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1255.58 ms 1272.51 ms 16.93 ms
Size 2.92 MiB 3.37 MiB 464.35 KiB

Previous results on branch: 5.0.0

Startup times

Revision Plain With Sentry Diff
d760caf1e2cc34c23ee063cc2a238073a802b99e+dirty 1258.76 ms 1292.66 ms 33.90 ms
b868b539c3533fede4a02dae8c2246ffa3dd5a8c+dirty 1253.68 ms 1253.94 ms 0.26 ms
d0912399fb99550cb61670c1957ca90079d4ca38+dirty 1261.62 ms 1275.80 ms 14.17 ms
58ae9301bc42b3eb99e6d9d74079d2db048a4a6a+dirty 1266.80 ms 1273.79 ms 6.99 ms
34dc25964442b05d4ae800980dc4be60660ed483+dirty 1283.72 ms 1289.30 ms 5.58 ms

App size

Revision Plain With Sentry Diff
d760caf1e2cc34c23ee063cc2a238073a802b99e+dirty 2.92 MiB 3.37 MiB 462.90 KiB
b868b539c3533fede4a02dae8c2246ffa3dd5a8c+dirty 2.92 MiB 3.30 MiB 387.19 KiB
d0912399fb99550cb61670c1957ca90079d4ca38+dirty 2.92 MiB 3.30 MiB 387.22 KiB
58ae9301bc42b3eb99e6d9d74079d2db048a4a6a+dirty 2.92 MiB 3.37 MiB 464.04 KiB
34dc25964442b05d4ae800980dc4be60660ed483+dirty 2.92 MiB 3.37 MiB 463.96 KiB

github-actions[bot] avatar Dec 14 '22 11:12 github-actions[bot]

Can I get a final review on this PR?

It's a lot of changes and the individual changes have been reviewed already. We just need to skim it, just in case something slipped thru.

krystofwoldrich avatar Feb 20 '23 14:02 krystofwoldrich

Looking forward to this for 0.69 :)

chrisedington avatar Feb 21 '23 10:02 chrisedington