sentry-react-native icon indicating copy to clipboard operation
sentry-react-native copied to clipboard

Report top level integrations on RN

Open marandaneto opened this issue 3 years ago • 1 comments

Similar to https://github.com/getsentry/sentry-java/issues/1989 but we already send all the integrations. It'd be useful to also send the routing libraries etc that are added manually, so we can learn the usage of it.

marandaneto avatar Apr 13 '22 15:04 marandaneto

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar May 21 '22 00:05 github-actions[bot]

@marandaneto Routing libraries you mean the js deps of a project? -> https://github.com/getsentry/team-mobile/issues/54

Would it also make sense to report which one of our routingInstrumentation is being used?

krystofwoldrich avatar Oct 27 '22 12:10 krystofwoldrich

@krystofwoldrich nope, I mean, ReactNavigationInstrumentation, ReactNavigationV4Instrumentation, ReactNativeTracing, RoutingInstrumentation , etc... every integration/router/navigator... that has to be added manually, we'd know which integrations are being set or not, also its usage.

marandaneto avatar Oct 27 '22 15:10 marandaneto

Seems like we should just change the name of the ReactNativeTracing integrations based on the used instrumentation since the ReactNativeTracing can only create Transaction for an app start.

Or create dummy integrations for ReactNavigationInstrumentation, ReactNavigationV4Instrumentation so they get picked up automatically.

krystofwoldrich avatar Oct 27 '22 18:10 krystofwoldrich