sentry-react-native icon indicating copy to clipboard operation
sentry-react-native copied to clipboard

Append missing context from Native SDK for iOS

Open marandaneto opened this issue 3 years ago • 1 comments

Similar to https://github.com/getsentry/sentry-dart/pull/761/files

Missing tags, extra, user, dist, environment, fingerprint, level, breadcrumbs... Ideally, every scope data set in the Native SDK makes it to the Events captured by JS as well.

marandaneto avatar Feb 22 '22 09:02 marandaneto

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Mar 16 '22 00:03 github-actions[bot]

Right RN -> iOS only merges the contexts and user, https://github.com/getsentry/sentry-react-native/blob/main/src/js/integrations/devicecontext.ts But it should merge/fill the missing objects as well the tags, extra, dist, environment, fingerprint, level, breadcrumbs.

marandaneto avatar Dec 07 '22 14:12 marandaneto

This might be a breaking change due to the inclusion of the event.fingerprint.

krystofwoldrich avatar Jan 03 '23 14:01 krystofwoldrich

This might be a breaking change due to the inclusion of the event.fingerprint.

That's fine, its part of the v5 milestone anyway.

marandaneto avatar Jan 03 '23 14:01 marandaneto