sentry-react-native icon indicating copy to clipboard operation
sentry-react-native copied to clipboard

iOS scripts respect `cli.executable` when custom value given

Open marandaneto opened this issue 4 years ago • 5 comments

reason: https://github.com/getsentry/sentry-react-native/issues/1857#issuecomment-976487521

The fix is probably under https://github.com/getsentry/sentry-wizard/blob/master/lib/Steps/Integrations/ReactNative.ts#L248

marandaneto avatar Nov 23 '21 12:11 marandaneto

Sorry to bother you again with this, but is there an ETA on implementing this? Might help giving some Sentry and Expo/EAS users some context 😄

byCedric avatar Nov 29 '21 18:11 byCedric

@byCedric no worries, unfortunately, we don't have an ETA since we are still prioritizing all the open issues, closing old ones, etc... hoping to work on that soon tho. would you like to submit a PR and patch the shell script on sentry-wizard?

pretty much what needs to be done is:

read cli.executable from the exported sentry.properties, and if not found, keep the hardcoded value, ../node_modules/@sentry/cli/bin/sentry-cli

we should do it just before https://github.com/getsentry/sentry-wizard/blob/master/lib/Steps/Integrations/ReactNative.ts#L248 and replace the hardcoded sentry-cli path with the variable that reads from cli.executable or fallback to the hardcoded one.

marandaneto avatar Nov 30 '21 07:11 marandaneto

ideally the integration could also try to find the correct folder, its done on Android https://github.com/getsentry/sentry-react-native/pull/1917

marandaneto avatar Dec 13 '21 09:12 marandaneto