sentry-react-native icon indicating copy to clipboard operation
sentry-react-native copied to clipboard

Document and test ErrorBoundary

Open bruno-garcia opened this issue 4 years ago • 5 comments

Perhaps some of the JS docs could be moved to an include and reused. But here we need to document why it's needed vs bubbling to the unhandled exception integration. And when/how the white screen rendering happens.

We have a user reported issue that the fallback isnt' working on React Native. Consider adding this test case to e2e.

bruno-garcia avatar Sep 17 '21 17:09 bruno-garcia

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Nov 04 '21 15:11 github-actions[bot]

@bruno-garcia can you link where this is already documented for JS?

I guess its https://docs.sentry.io/platforms/javascript/guides/react/components/errorboundary/ just to confirm, is it a React thing only?

marandaneto avatar Nov 08 '21 13:11 marandaneto

ping @bruno-garcia

marandaneto avatar Nov 18 '21 09:11 marandaneto

ping @bruno-garcia

Sorry, I don't keep up with GH notifications anymore. Please drop me a link via DM if I'm blocking?

@bruno-garcia can you link where this is already documented for JS?

https://github.com/getsentry/sentry-docs/search?q=ErrorBoundary

I guess its docs.sentry.io/platforms/javascript/guides/react/components/errorboundary just to confirm, is it a React thing only?

Yes

bruno-garcia avatar Nov 28 '21 17:11 bruno-garcia

Is ErrorBoundary (import { ErrorBoundary } from '@sentry/react-native') supposed to be used & working?

I can't find docs about it but the export from @sentry/react-native definitely exists.

wouterds avatar Nov 25 '22 16:11 wouterds

Hi, the ErrorBoundary should work the same as in Browser React.

Here are docs for it: https://docs.sentry.io/platforms/javascript/guides/react/features/error-boundary/

krystofwoldrich avatar Nov 28 '22 11:11 krystofwoldrich