sentry-python icon indicating copy to clipboard operation
sentry-python copied to clipboard

tests: reorder to unpin pytest

Open rominf opened this issue 1 year ago • 2 comments

Fix: #3035

Rearrange test items so that forked tests come before normal tests within their respective modules. Swap the last forked test with the last normal test if necessary.

Workaround to unpin pytest. See: https://github.com/pytest-dev/pytest/issues/9621, https://github.com/pytest-dev/pytest-forked/issues/67, and specifically: https://github.com/pytest-dev/pytest-forked/issues/67#issuecomment-1964718720


Thank you for contributing to sentry-python! Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. The AWS Lambda tests additionally require a maintainer to add a special label, and they will fail until this label is added.

rominf avatar Oct 02 '24 14:10 rominf

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.23%. Comparing base (5080c76) to head (2627a60). Report is 55 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3598      +/-   ##
==========================================
- Coverage   84.34%   84.23%   -0.11%     
==========================================
  Files         133      133              
  Lines       13929    13929              
  Branches     2938     2938              
==========================================
- Hits        11748    11733      -15     
- Misses       1443     1458      +15     
  Partials      738      738              

see 6 files with indirect coverage changes

codecov[bot] avatar Oct 02 '24 14:10 codecov[bot]

By some reason approach does not work on Python 3.6, Python 3.7 (works on later versions of Python). I will investigate.

rominf avatar Oct 02 '24 14:10 rominf

Superseded by the following PRs:

  • https://github.com/getsentry/sentry-python/pull/3696
  • https://github.com/getsentry/sentry-python/pull/3700
  • https://github.com/getsentry/sentry-python/pull/3701
  • https://github.com/getsentry/sentry-python/pull/3714

szokeasaurusrex avatar Oct 29 '24 13:10 szokeasaurusrex