sentry-python icon indicating copy to clipboard operation
sentry-python copied to clipboard

Fix Scope tests

Open antonpirker opened this issue 1 year ago • 2 comments

Fix the Scope related tests in Potel.

antonpirker avatar Oct 01 '24 13:10 antonpirker

:x: 4467 Tests Failed:

Tests completed Failed Passed Skipped
16467 4467 12000 1591
View the top 3 failed tests by shortest run time
tests.integrations.clickhouse_driver.test_clickhouse_driver test_clickhouse_dbapi_breadcrumbs_with_pii
Stack Traces | 0s run time
No failure message available
tests.integrations.clickhouse_driver.test_clickhouse_driver test_clickhouse_dbapi_spans_with_pii
Stack Traces | 0s run time
No failure message available
tests.integrations.starlette.test_starlette test_user_information_error
Stack Traces | 0s run time
No failure message available

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

codecov[bot] avatar Oct 01 '24 13:10 codecov[bot]

In POTel this only works when there is this with sentry_sdk.start_span() in the test, because this is the point where our scopes are put on the OTel context.

This should also work without having a span. @sl0thentr0py said he will implement a switch to switch to Otel and in that case the Sentry scopes will be put on the OTel context during SDK init().

So I will leave this Issue here until it is time to implement that switch.

antonpirker avatar Oct 07 '24 14:10 antonpirker

This is now outdated. Will close.

antonpirker avatar Dec 05 '24 13:12 antonpirker