sentry-python icon indicating copy to clipboard operation
sentry-python copied to clipboard
verified publisher icon getsentry

Remove `runtox.sh`

Open antonpirker opened this issue 1 year ago • 2 comments

The functionality of runtox.sh can be also done with tox -f so I will remove the shell script to simplify things.

antonpirker avatar Sep 30 '24 15:09 antonpirker

:x: 449 Tests Failed:

Tests completed Failed Passed Skipped
29430 449 28981 5316
View the top 3 failed tests by shortest run time 
 tests.integrations.arq.test_arq
Stack Traces | 0s run time 
No failure message available

 tests.integrations.grpc.test_grpc
Stack Traces | 0s run time 
No failure message available

 tests.integrations.starlette.test_starlette
Stack Traces | 0s run time 
No failure message available

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

codecov[bot] avatar Sep 30 '24 15:09 codecov[bot]

There is one problem with this: We group different frameworks together in one YAML file (like all database integrations) and those integrations need different Python versions to test on. The YAML has specified a union of all the Python verisons needed.

When we run tox -f for a Python version and framework combination that is not specified in tox.ini then the tox command fails with the same exit code then it would when the test are run but failing. So we can not decide on that level if the Github actions failed or succeeded (meaning no tests to run, continue).

So I will park this PR for now.

antonpirker avatar Oct 01 '24 07:10 antonpirker

will not do this right now. Closing

antonpirker avatar Mar 21 '25 08:03 antonpirker