sentry-python icon indicating copy to clipboard operation
sentry-python copied to clipboard

Auto enable Litestar integration

Open provinzkraut opened this issue 1 year ago • 2 comments

Auto enable the Litestar integration added in #3358.


Thank you for contributing to sentry-python! Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. The AWS Lambda tests additionally require a maintainer to add a special label, and they will fail until this label is added.

provinzkraut avatar Sep 13 '24 18:09 provinzkraut

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.90%. Comparing base (e9ec6c1) to head (38cbfdc). Report is 2 commits behind head on master.

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3540      +/-   ##
==========================================
+ Coverage   79.89%   79.90%   +0.01%     
==========================================
  Files         137      137              
  Lines       15373    15373              
  Branches     2609     2609              
==========================================
+ Hits        12282    12284       +2     
+ Misses       2221     2219       -2     
  Partials      870      870              
Files with missing lines Coverage Δ
sentry_sdk/integrations/__init__.py 81.81% <ø> (ø)

... and 1 file with indirect coverage changes

codecov[bot] avatar Sep 23 '24 08:09 codecov[bot]

Hey @provinzkraut, thanks for the PR -- we can merge this once the Litestar integration has been available for some time. I'd wait for couple more releases. We also have a new major coming up soonish (probably still this year) so if we don't enable the integration until then, SDK 3.0 would be a good point to do it.

sentrivana avatar Oct 01 '24 14:10 sentrivana