sentry-python icon indicating copy to clipboard operation
sentry-python copied to clipboard

ref(otel): Remove autoinstrumentation

Open sentrivana opened this issue 1 year ago • 1 comments

Removing experimental OTel autoinstrumentation since we want to focus on getting basic OTel support right. Once we're confident that our instrumentation works correctly with OTel, we can focus on adding OTel integration packages.

We can reuse some stuff this PR removes then, if necessary.

Closes https://github.com/getsentry/sentry-python/issues/3238

sentrivana avatar Jul 03 '24 12:07 sentrivana

Codecov Report

Attention: Patch coverage is 65.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 79.72%. Comparing base (6bb2081) to head (08df6aa).

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3239      +/-   ##
==========================================
- Coverage   79.76%   79.72%   -0.05%     
==========================================
  Files         133      132       -1     
  Lines       14313    14237      -76     
  Branches     3012     2997      -15     
==========================================
- Hits        11417    11350      -67     
+ Misses       2074     2065       -9     
  Partials      822      822              
Files Coverage Δ
...ntry_sdk/integrations/opentelemetry/integration.py 63.33% <65.00%> (-13.48%) :arrow_down:

... and 3 files with indirect coverage changes

codecov[bot] avatar Jul 03 '24 18:07 codecov[bot]

didn't we want to keep the distro setup for later?

sl0thentr0py avatar Jul 23 '24 12:07 sl0thentr0py

didn't we want to keep the distro setup for later?

The distro setup mostly makes sense if we're using OTel's autodiscovery of instrumentation packages. But since we now want to enable integrations one by one explicitly, we can get rid of the distro stuff. (It also wasn't a "real" distro in the sense of how it should be used. So all in all better to get rid of it to not confuse people.)

sentrivana avatar Jul 23 '24 13:07 sentrivana