sentry-python icon indicating copy to clipboard operation
sentry-python copied to clipboard

fix(grpc): Return proper metadata object instead of list in…

Open fdellekart opened this issue 1 year ago • 5 comments

Fix wrong metadata type in async gRPC interceptor

Fixes #2509

The metadata of gRPC calls was transformed to a list in the client interceptor. The list was compatible with gRPC itself as it is the format for metadata in the sync version, however it lead to downstream interceptors crashing as they expected a grpc.aio.Metadata object.

This PR now uses the expected type.

fdellekart avatar Jun 26 '24 20:06 fdellekart

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.87%. Comparing base (3e43a91) to head (34725e8). Report is 1 commits behind head on master.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/integrations/grpc/aio/client.py 60.00% 1 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3205      +/-   ##
==========================================
- Coverage   79.90%   79.87%   -0.03%     
==========================================
  Files         137      137              
  Lines       15385    15387       +2     
  Branches     2611     2613       +2     
==========================================
- Hits        12293    12290       -3     
- Misses       2220     2223       +3     
- Partials      872      874       +2     
Files with missing lines Coverage Δ
sentry_sdk/integrations/grpc/aio/client.py 94.44% <60.00%> (-5.56%) :arrow_down:

... and 1 file with indirect coverage changes

codecov[bot] avatar Jun 26 '24 20:06 codecov[bot]

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

getsantry[bot] avatar Aug 09 '24 07:08 getsantry[bot]

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

getsantry[bot] avatar Sep 03 '24 07:09 getsantry[bot]

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

getsantry[bot] avatar Sep 30 '24 07:09 getsantry[bot]

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

getsantry[bot] avatar Oct 22 '24 07:10 getsantry[bot]

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

getsantry[bot] avatar Nov 12 '24 08:11 getsantry[bot]

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

getsantry[bot] avatar Dec 04 '24 08:12 getsantry[bot]

@szokeasaurusrex please get this merged if it's a valid change otherwise close it. Resetting the clock.

sl0thentr0py avatar Dec 04 '24 14:12 sl0thentr0py