sentry-python icon indicating copy to clipboard operation
sentry-python copied to clipboard

Make ClickHouse integration work with `django-clickhouse-backend`

Open sentrivana opened this issue 1 year ago • 0 comments

Problem Statement

The ClickHouse integration doesn't create spans if used in Django via django-clickhouse-backend.

This first surfaced in https://github.com/getsentry/sentry-python/issues/3088 where the whole integration would error out because _sentry_span was not set on the connection as expected. We're patching the integration to not do anything if _sentry_span is not there, but it'd be good to have proper support for django-clickhouse-backend.

Solution Brainstorm

Looks like the spans are not started the expected way (clickhouse_driver.connection.Connection.send_query is not called?), so we might need to wrap an additional function that django-clickhouse-backend uses to start queries.

sentrivana avatar May 22 '24 13:05 sentrivana