sentry-python icon indicating copy to clipboard operation
sentry-python copied to clipboard

feat(tests): Add a Starlette testcase that uses Uvicorn

Open sentrivana opened this issue 1 year ago • 1 comments

Follow up to detect regressions like https://github.com/getsentry/sentry-python/issues/3021. Verified that the new test fails if I reintroduce the async ensure decorator.

The new Uvicorn fixture might be also useful for other tests.

Also took the liberty to update the Starlette versions in Tox.

Relates https://github.com/getsentry/sentry-python/issues/2892

WIP: works locally. freezes in ci.


General Notes

Thank you for contributing to sentry-python!

Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. Some tests (AWS Lambda) additionally require a maintainer to add a special label to run and will fail if the label is not present.

For maintainers

Sensitive test suites require maintainer review to ensure that tests do not compromise our secrets. This review must be repeated after any code revisions.

Before running sensitive test suites, please carefully check the PR. Then, apply the Trigger: tests using secrets label. The label will be removed after any code changes to enforce our policy requiring maintainers to review all code revisions before running sensitive tests.

sentrivana avatar Apr 26 '24 11:04 sentrivana

:x: 1 Tests Failed:

Tests completed Failed Passed Skipped
13523 1 13522 4121
View the top 1 failed tests by shortest run time
tests.integrations.stdlib.test_httplib test_http_timeout
Stack Traces | 61.2s run time
.../integrations/stdlib/test_httplib.py:373: in test_http_timeout
    assert len(transaction["spans"]) == 1
E   assert 6 == 1
E     +6
E     -1

To view more test analytics, go to the Test Analytics Dashboard Got feedback? Let us know on Github

codecov[bot] avatar Oct 01 '24 09:10 codecov[bot]