sentry-python
sentry-python copied to clipboard
getsentry
feat(integrations): Add support for celery-redbeat cron tasks
This add support for celery-redbeat (resolves #2616). Thanks to https://github.com/getsentry/sentry-python/issues/2616#issuecomment-1875438310
General Notes
Thank you for contributing to sentry-python!
Please add tests to validate your changes, and lint your code using tox -e linters.
Running the test suite on your PR might require maintainer approval. Some tests (AWS Lambda) additionally require a maintainer to add a special label to run and will fail if the label is not present.
For maintainers
Sensitive test suites require maintainer review to ensure that tests do not compromise our secrets. This review must be repeated after any code revisions.
Before running sensitive test suites, please carefully check the PR. Then, apply the Trigger: tests using secrets label. The label will be removed after any code changes to enforce our policy requiring maintainers to review all code revisions before running sensitive tests.
Hey @kwigley, sorry for the wait.
I've tried the PR but it doesn't work for me -- did it work for you? As far as I can tell the problem is we attempt to patch the RedBeatScheduler class, but we're not patching it in the right place or at the right time, because when I run this, only the original maybe_due is called, but not our wrapped one. Lmk if the code worked for you as is -- in that case it might be something with my setup.
Ok it was a problem with my setup (and our docs :) ) -- I'm getting monitors now. Will give the PR one more look but looks good at first glance!
Ok it was a problem with my setup (and our docs :) ) -- I'm getting monitors now. Will give the PR one more look but looks good at first glance!
ah, missed your previous comment. Sounds good! lmk if you need anything else
@kwigley All good, no action needed on your end, this is good to merge. Thank you!