sentry-python icon indicating copy to clipboard operation
sentry-python copied to clipboard

Django integration does not respect SCRIPT_NAME

Open ethrgeist opened this issue 2 years ago • 3 comments

How do you use Sentry?

Self-hosted/on-premise

Version

self-hosted-23.11.2

Steps to Reproduce

  1. Django setup with SCRIPT_NAME=/foo/bar under domain example.net
  2. Full url https://example.net/foo/bar/
  3. Triggern an error in a view https://example.net/foo/bar/my-view/
  4. URL in Sentry UI is just https://example.net/my-view/, missing the SCRIPT_NAME

Expected Result

URL should respect SCRIPT_NAME and the link in the UI should be https://example.net/foo/bar/my-view/

Actual Result

URL in Sentry UI is just https://example.net/my-view/

ethrgeist avatar Dec 10 '23 21:12 ethrgeist

Hey @ethrgeist ! Thanks for reporting this. Makes total sense. I put it on our list, but also marked it as good first issue and help wanted, so maybe someone wants to jump on this.

antonpirker avatar Dec 11 '23 09:12 antonpirker

Apologies for the multiple PRs, got a bit confused but it seems like we need to add the Trigger: tests using secrets label to the PR in order for checks to pass. Could anyone help me out with that?

sarvaSanjay avatar Jan 09 '24 14:01 sarvaSanjay

Apologies for the multiple PRs, got a bit confused but it seems like we need to add the Trigger: tests using secrets label to the PR in order for checks to pass. Could anyone help me out with that?

Yes @sarvaSanjay – only maintainers can add this label. We will add the label once all other tests are passing and the change has been approved.

I took a look at your PR and added some comments. Once you address these comments and get the tests to pass, we can hopefully get this change merged.

szokeasaurusrex avatar Jan 10 '24 14:01 szokeasaurusrex