sentry-python icon indicating copy to clipboard operation
sentry-python copied to clipboard

Support Litestar

Open sentrivana opened this issue 2 years ago • 7 comments

Problem Statement

Starlite was renamed to Litestar. Since we already have a Starlite integration, adding support for Litestar should in the ideal case just be a matter of checking the changelog for the new major and creating a new integration based on the existing one.

Solution Brainstorm

Write the new integration.

sentrivana avatar Oct 04 '23 12:10 sentrivana

Hi! Let us know if there is any extra details that may be helpful in this. We may have some resources we can throw at this to tackle the PR but I am doubtful as it stands right now (at least for a little while!).. but we would love to see native support for this as well :)

JacobCoffee avatar Dec 08 '23 19:12 JacobCoffee

Hey @JacobCoffee, thanks for the support! Same goes the other way -- if anyone feels like tackling this, we're happy to provide support. The case of Litestar as an integration is special since we've already integrated with Starlite, so whoever takes this on doesn't have to start from square one but rather build on what we already have, which should make it easier.

Folks reading this, please give the original issue a 👍🏻 if this is something you want, it helps us prioritize this internally as well.

sentrivana avatar Dec 11 '23 09:12 sentrivana

@sentrivana I'd like to take a crack at this. I looked at the existing integration with Starlite, and like you said it shouldn't be too difficult to use that as a base for the Litestar integration.

vkcku avatar Dec 12 '23 01:12 vkcku

Thank you @guacs! Exactly, I'd start by just copying the Starlite integration into a new file and then taking it from there. Additionally there is a few housekeeping places that will need changing throughout the SDK, like adding Litestar to tox.ini, to our GitHub workflow generator script, adding some span OP constants, etc. -- for updating those you can just grep for starlite and add the same for litestar.

sentrivana avatar Dec 12 '23 08:12 sentrivana

@sentrivana @guacs any news on this?

jeanlst avatar Jan 15 '24 14:01 jeanlst

No news yet @jeanlst -- same situation as before, we probably won't get around to doing this soon, but happy to provide support if anyone wants to give it a try.

sentrivana avatar Jan 15 '24 14:01 sentrivana

@sentrivana @guacs any news on this?

Sorry I've just gotten quite busy for a while! Unfortunately, I think it may be a few weeks before I'll get a chance to work on this :/

vkcku avatar Jan 16 '24 07:01 vkcku