sentry-python icon indicating copy to clipboard operation
sentry-python copied to clipboard

Add wrapper for `Celery().send_task` to support behavior as `Task.apply_async`

Open divaltor opened this issue 1 year ago • 2 comments

Close #2372

I've looked at code and decided to add the same wrapper to send_task as for apply_async because there is almost no difference besides args variable.

And inside test I checked if redis pipeline is worked with send_task and apply_async as well, but considering bug with tox --parallel I think there is some points to improve

divaltor avatar Sep 16 '23 11:09 divaltor

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

getsantry[bot] avatar Oct 18 '23 07:10 getsantry[bot]

Any review?

divaltor avatar Oct 22 '23 14:10 divaltor

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.66%. Comparing base (2c1e31c) to head (5dcade7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2377      +/-   ##
==========================================
- Coverage   79.71%   79.66%   -0.05%     
==========================================
  Files         132      132              
  Lines       14264    14270       +6     
  Branches     3003     3004       +1     
==========================================
- Hits        11370    11368       -2     
- Misses       2071     2084      +13     
+ Partials      823      818       -5     
Files Coverage Δ
sentry_sdk/integrations/celery/__init__.py 87.28% <100.00%> (+0.33%) :arrow_up:

... and 2 files with indirect coverage changes

codecov[bot] avatar Jul 25 '24 20:07 codecov[bot]