sentry-python [Feat] Starlite Integration

Problem Statement

Starlite us an ASGI framework based partially on Starlette. The current Starlette integration is not compatible with it because Starlite has its own routing and exception handling solutions in place. So the feature request here is to create an integration for Starlite.

Solution Brainstorm

Starlite has both exception handlers and life-cycle hooks (see the docs for more details) and these can be used to create a sentry integration. Furthermore, if need be we can add more lifecycle hooks to Starlite as required.

Aug 06 '22 06:08 Goldziher

hi @Goldziher our own development priorities get set through internal quarterly goals, so we'll keep this on the backlog for now. PRs are always welcome if you want some feature sooner! And if I gather correctly, you are the Starlite maintainer, so one from you would be even more welcome. :)

Aug 08 '22 09:08 sl0thentr0py

hi @Goldziher our own development priorities get set through internal quarterly goals, so we'll keep this on the backlog for now. PRs are always welcome if you want some feature sooner! And if I gather correctly, you are the Starlite maintainer, so one from you would be even more welcome. :)

Great. Yes, Im one of the maintainers. If time allows we will contribute a PR here.

Aug 08 '22 11:08 Goldziher

Would be awesome @Goldziher! the FastAPI integration for example was to start a wrapper around Starlette, Maybe Starlite could start in a similar pattern?

Aug 30 '22 11:08 smeubank

Im working now on a PR that adds application level hooks for instrumentation. Once this is done, we will be able to create an integration with more ease and without needing to wrap the application - which is prone to introduce some issues and create typing problems.

See this for reference: https://github.com/starlite-api/starlite/issues/350, and please comment on that issue if something is required in your opinion(s).

Draft PR: https://github.com/starlite-api/starlite/pull/435 - expected to be finished today or tomorrow.

Aug 30 '22 12:08 Goldziher

@smeubank -- have you seen the open PR adding the Starlite integration? the reason I am asking, we have users who need this feature.

Nov 26 '22 08:11 Goldziher

Hi @Goldziher

no i did not see the PR yet, but just found from the link. We are in the midst of some quarterly work and folks taking time off for the holidays. I will try to see if we can get some eyes on it next week. And get you some feedback.

Dec 02 '22 13:12 smeubank

any movement here @smeubank ?

Dec 30 '22 12:12 Goldziher

hi @Goldziher

thanks for the reminder, resurfaced with the team. We agree we want to get this in and will have another python SDK dev back from holidays next week. We will put it in our to do list for then

Hope that timeline is OK for you, I know you started work on this quite some time back

Jan 03 '23 13:01 smeubank

hi @Goldziher

thanks for the reminder, resurfaced with the team. We agree we want to get this in and will have another python SDK dev back from holidays next week. We will put it in our to do list for then

Hope that timeline is OK for you, I know you started work on this quite some time back

Thanks 🙏.

Jan 03 '23 15:01 Goldziher