sentry-python icon indicating copy to clipboard operation
sentry-python copied to clipboard

parent_span_id being attached to root celerybeat transactions

Open wmak opened this issue 3 years ago • 3 comments

Environment

How do you use Sentry? Sentry SaaS (sentry.io)

Which SDK and version? sentry-python==1.0.0

Steps to Reproduce

https://gist.github.com/wmak/fffab40bdbe5329f2ef8bd0a4ff44659

  1. Repro project attached, a very basic flask app with an endpoint that starts a celery task + a celerybeat that starts the same task
  2. Setup the repro project
  3. Run redis on 6379
  4. Start the celery worker celery -A main.celery worker
  5. Start celery beat celery -A main.celery beat --loglevel=INFO --pidfile=''
  6. Wait for the task to be scheduled

Expected Result

I don't expect for celery tasks started by celerybeat to have the parent_span_id set to a span_id, especially when there isn't a corresponding transaction with that span to make the association, the repro attached here is flask + celerybeat. But also happens with Django + celerybeat

Actual Result

The parent_span_id was set in the trace context, so the transaction appears to be orphaned, when it in fact should be a root event instead image

wmak avatar Apr 22 '21 00:04 wmak

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Dec 23 '21 15:12 github-actions[bot]

Hello @wmak Thanks for writting in. Sorry this issue slipped through the cracks. This is a really good point, and I think this is a bug that we should address.

As this bug report is already quite old, could you please verify this with the latest Sentry SDK? Thanks!

antonpirker avatar Feb 22 '22 09:02 antonpirker

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Mar 18 '22 00:03 github-actions[bot]