sentry-python
sentry-python copied to clipboard
parent_span_id being attached to root celerybeat transactions
Environment
How do you use Sentry? Sentry SaaS (sentry.io)
Which SDK and version? sentry-python==1.0.0
Steps to Reproduce
https://gist.github.com/wmak/fffab40bdbe5329f2ef8bd0a4ff44659
- Repro project attached, a very basic flask app with an endpoint that starts a celery task + a celerybeat that starts the same task
- Setup the repro project
- Run redis on 6379
- Start the celery worker
celery -A main.celery worker
- Start celery beat
celery -A main.celery beat --loglevel=INFO --pidfile=''
- Wait for the task to be scheduled
Expected Result
I don't expect for celery tasks started by celerybeat to have the parent_span_id set to a span_id, especially when there isn't a corresponding transaction with that span to make the association, the repro attached here is flask + celerybeat. But also happens with Django + celerybeat
Actual Result
The parent_span_id was set in the trace context, so the transaction appears to be orphaned, when it in fact should be a root event instead
This issue has gone three weeks without activity. In another week, I will close it.
But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog
or Status: In Progress
, I will leave it alone ... forever!
"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀
Hello @wmak Thanks for writting in. Sorry this issue slipped through the cracks. This is a really good point, and I think this is a bug that we should address.
As this bug report is already quite old, could you please verify this with the latest Sentry SDK? Thanks!
This issue has gone three weeks without activity. In another week, I will close it.
But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog
or Status: In Progress
, I will leave it alone ... forever!
"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀