sentry-plugins icon indicating copy to clipboard operation
sentry-plugins copied to clipboard

feat(clubhouse): Add global search

Open miketheman opened this issue 7 years ago • 5 comments

Add a configuration for the user to opt-in for a Sentry project to search across all Clubhouse projects. When the flag is active, skip adding the configured Clubhouse project ID to the search.

Resolves #344

Signed-off-by: Mike Fiedler [email protected]

miketheman avatar Nov 18 '18 14:11 miketheman

Example UI looks like this:

screen shot 2018-11-18 at 9 43 55 am

Not sure what's going on with the CSS and alignment - that's likely somewhere in sentry core?

miketheman avatar Nov 18 '18 14:11 miketheman

Amazing, thanks @miketheman !

mkj28 avatar Nov 19 '18 05:11 mkj28

@markstory Definitely makes sense to have one - I was having trouble finding any examples in the codebase that do configuration validation/mocking and then subsequently testing the resulting request. Can you point me in the right direction?

miketheman avatar Nov 19 '18 17:11 miketheman

So is the desire to no longer have this? Happy to disengage from contributing to the project if it's no longer desired.

miketheman avatar Nov 20 '19 22:11 miketheman

Hi @miketheman - closed the PR as this repo is going into archive mode soon and the PR had some merge conflicts. It needs to be ported over to getsentry/sentry anyway for us to merge. If you are still interested, would you mind porting this over to https://github.com/getsentry/sentry/tree/master/src/sentry_plugins/clubhouse ?

Sorry for the trouble! Also ping @markstory

BYK avatar Nov 20 '19 23:11 BYK