sentry-php icon indicating copy to clipboard operation
sentry-php copied to clipboard

Add `profiles_sampler` option similar to `traces_sampler`

Open cleptric opened this issue 1 year ago • 0 comments

Discussed in https://github.com/getsentry/sentry-php/discussions/1550

Originally posted by tadz June 19, 2023 As of v3.15.0 there is an option config profiles_sample_rate and it's value is relative to traces_sample_rate. I am able to define transactions that have different traces_sample_rate by defining traces_sampler function. I want to be able to define profiles_sample_rate in same manner by providing profiles_sampler function.

Example: I've defined traces_sampler to return 0.1 for all transactions (default) I've defined profiles_sample_rate to return 0.01

I've defined traces_sampler to return 0.0001 for transactionA and transactionB I want to define profiles_sample_rate to return 1.0 for transactionA and transactionB to send same amount of profiles as traces

these transactions are manually triggered with startTransaction so for now I'll use init function with new options but it would be better to define that as profiles_sampler function


We already added the option to Python, so let's also add it to PHP.

cleptric avatar Jun 19 '23 14:06 cleptric