sentry-php icon indicating copy to clipboard operation
sentry-php copied to clipboard

Timeout is not supported like stated in the docs?

Open PurHur opened this issue 3 years ago • 3 comments

How do you use Sentry?

Self-hosted/on-premise

Version

3

Steps to Reproduce

  1. Have a lot of applications
  2. Log a lot of stuff
  3. Do nothing but let sentry crash randomly (Or shut it off)
  4. Crash all other apps because sentry is not responding anymore.

Expected Result

Not crashing all applications which use the sentry server

Actual Result

Hello,

i have a question about the docs and answers i found here in PRs/Issues.

Its about a timeout the api (should) provide when contacting a sentry server. https://docs.sentry.io/platforms/php/configuration/options/

The docs define two http_connect_timeout and http_timeout. Which indicate that the client has an option to use a timeout. But issues like this: https://github.com/getsentry/sentry-php/pull/967 Tell me that the options isnt used? I couldnt find a line in the code that its really passend by so i am now curios if the SDK still supports a default timeout out of the box, without setting a special HTTPclient. There are multiple issues like that. They describe the problem Sentry has passing around the timeout options to custom clients and so its not implemented anymore (silently???)

So is the timeout option still in use? It is supposed to be documented?

PurHur avatar Aug 23 '22 16:08 PurHur

Tell me that the options isnt used? I couldnt find a line in the code that its really passend by

Support for configuring one of the out-of-the-box supported HTTP clients using the http_connect_timeout and http_timeout options have been implemented in #1282. Is this what you are looking for?

ste93cry avatar Aug 23 '22 16:08 ste93cry

Yes thank you. I will look for deployed code on my side but your hint to the PR does REALY help to tell my boss there is a timeout. I will have to confirm that this is deployed to the current packages since i am not saw any "timeout" in the current code. But really thank you showing me the lines.

Edit: To be clear: My boss suspects Sentry to be a major fault of many servers again!!! to get offline. I told him "No they implemented the timeout!". Looks like the timeout was implemented in May?! It was implemented sometime between a lot of users told Sentry that a timeout is very needed and put a lot of apps down.

PurHur avatar Aug 23 '22 18:08 PurHur

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Sep 20 '22 00:09 github-actions[bot]