sentry-php icon indicating copy to clipboard operation
sentry-php copied to clipboard

Unable to configure http plugins

Open xepozz opened this issue 3 years ago • 8 comments

You are creating Error plugin directly in code. That's why I can't pass my own config to that plugin.

How can I configure these plugins?

xepozz avatar Jun 28 '21 14:06 xepozz

Actually there is no easy way to configure the plugins, the best thing I can suggest you is to create your own HTTP client factory to set them

ste93cry avatar Jun 29 '21 19:06 ste93cry

It makes some problems to simple update package.

xepozz avatar Jul 01 '21 17:07 xepozz

I'm not sure I get what you mean 🤔

ste93cry avatar Jul 02 '21 19:07 ste93cry

When you update http client factory I can't just update the package and use new features. What's the problem to add ability to configure factory's behaviour?

xepozz avatar Aug 03 '21 10:08 xepozz

What's the problem to add ability to configure factory's behaviour?

There's no problem, besides the fact that my opinion is that the less code we have to maintain the better it is for everyone. So, if there is a real need for you to being able to customize the plugins we add then we can find a solution, but if you just want to add more plugins then something like the PluggableHttpClientFactory that was present in version 2.x is enough and can be implemented directly in your project

ste93cry avatar Aug 03 '21 19:08 ste93cry

I can't just overwrite HttpClientFactory. You don't use DI to use this class. I also need to overwrite TransportFactory. It's not the best thing that I would like do.

xepozz avatar Aug 04 '21 12:08 xepozz

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Jan 12 '22 21:01 github-actions[bot]

Don't forget about it :)

xepozz avatar Jan 15 '22 10:01 xepozz

I don't think this is something worth adding to the SDK itself, as this sounds like something people need very rarely.

cleptric avatar Aug 18 '22 11:08 cleptric