sentry-native icon indicating copy to clipboard operation
sentry-native copied to clipboard

feat: Update Crashpad and register WER handler

Open Swatinem opened this issue 3 years ago • 2 comments

Crashpad added a new WER (Windows Error Reporting) handler which needs to be manually registered first in the Windows Registry, and then with the crashpad client.

This depends on https://github.com/getsentry/crashpad/pull/69

Swatinem avatar Jul 18 '22 11:07 Swatinem

Good think our CI caught this:

  • The Windows SDK used to build the projects needs to be at least version 19041 to provide the required header struct definitions.
  • Other functions that crashpad calls are available since Windows 7.

We should be able to make all this conditional depending on the exact version customers want to target. We had a couple of requests and PRs to support XP, but officially we don’t really guarantee support, so things could potentially break at any time if people are targetting XP.

Either way, I would wait for @supervacuus to be back to help with the correct cmake and ifdefs for conditional compilation here.

Swatinem avatar Jul 18 '22 11:07 Swatinem

Codecov Report

Merging #735 (ef24d88) into master (58cbac4) will decrease coverage by 0.03%. The diff coverage is 100.00%.

:exclamation: Current head ef24d88 differs from pull request most recent head 9cdd9bc. Consider uploading reports for the commit 9cdd9bc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #735      +/-   ##
==========================================
- Coverage   83.09%   83.05%   -0.04%     
==========================================
  Files          53       53              
  Lines        5017     5017              
  Branches     1100     1100              
==========================================
- Hits         4169     4167       -2     
- Misses        737      738       +1     
- Partials      111      112       +1     

codecov-commenter avatar Aug 04 '22 15:08 codecov-commenter