sentry-native icon indicating copy to clipboard operation
sentry-native copied to clipboard

Update build docs for windows

Open kristjanvalur opened this issue 3 years ago • 3 comments

Some windows build tips gathered by trial and error. Probably needs formatting and entering to whatever source editor was used to create the Readme :)

kristjanvalur avatar Apr 23 '21 09:04 kristjanvalur

So, what do we do with this? Looking at Readme.md, it looks to me as it comes from some external editor. This PR was not really meant for direct pulling, rather as a suggestion for updates.

kristjanvalur avatar Apr 26 '21 09:04 kristjanvalur

Its just how my vscode (or actually prettier) autoformatted that, so no problem. I can also just copy-paste this in.

Swatinem avatar Apr 27 '21 09:04 Swatinem

Right, but you probably do want to edit it for style. So feel free to just grab whatever from it and close the PR :)

þri., 27. apr. 2021 kl. 09:02 skrifaði Arpad Borsos < @.***>:

Its just how my vscode (or actually prettier) autoformatted that, so no problem. I can also just copy-paste this in.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/getsentry/sentry-native/pull/528#issuecomment-827444001, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABN3FRYHZYM7CXZT3SVF5QLTKZ4SVANCNFSM43OHVCAA .

kristjanvalur avatar Apr 27 '21 09:04 kristjanvalur

The raised topics in this PR concerning the CMake config/build parameters when using the MSBuild generator are all valid points. But I think we covered them in the docs a while back by providing more contrasting build examples: https://docs.sentry.io/platforms/native/#install

supervacuus avatar Feb 08 '23 11:02 supervacuus