sentry-kotlin-multiplatform icon indicating copy to clipboard operation
sentry-kotlin-multiplatform copied to clipboard

fix(apple): remove sentry frames from stacktrace (testing only)

Open buenaflor opened this issue 1 year ago • 1 comments

:scroll: Description

Before fix:

image

After fix:

Screenshot 2024-05-16 at 04 15 29

:bulb: Motivation and Context

Fixes https://github.com/getsentry/sentry-kotlin-multiplatform/issues/77

:green_heart: How did you test it?

Unit tests

:pencil: Checklist

You have to check all boxes before merging:

  • [ ] I reviewed the submitted code.
  • [ ] I added tests to verify the changes.
  • [ ] No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • [ ] I updated the docs if needed.
  • [ ] Review from the native team if needed.
  • [ ] No breaking change or entry added to the changelog.

:crystal_ball: Next steps

buenaflor avatar May 16 '24 02:05 buenaflor

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.52%. Comparing base (1c5183c) to head (4e0ebe3).

:exclamation: Current head 4e0ebe3 differs from pull request most recent head 2de58cc. Consider uploading reports for the commit 2de58cc to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #223   +/-   ##
=======================================
  Coverage   78.52%   78.52%           
=======================================
  Files          31       31           
  Lines         419      419           
  Branches       56       56           
=======================================
  Hits          329      329           
  Misses         64       64           
  Partials       26       26           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 16 '24 02:05 codecov[bot]

Closing as this was only a test

buenaflor avatar Jun 05 '24 10:06 buenaflor