sentry-javascript icon indicating copy to clipboard operation
sentry-javascript copied to clipboard

Minified react producing bad stacktraces

Open smeubank opened this issue 1 year ago • 3 comments

Is there an existing issue for this?

  • [X] I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
  • [X] I have reviewed the documentation https://docs.sentry.io/
  • [X] I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which package are you using?

@sentry/react

SDK Version

7.8.0

Framework Version

No response

Link to Sentry event

https://sentry.io/organizations/sentry/releases/frontend%40b4a2b68ac44f0cf5319603a83190f09e780492aa/?issuesType=new&project=11276

Steps to Reproduce

see actual result for idea of why this happens

Expected Result

quality stack traces which link to the line with the render error

Actual Result

Checking any of those errors, the stacktraces seem a bit trashy. Via on the Workflow team, his understanding about why this happens is:

but no, when react gets minified you lose some error context, the lines shown are just where the state gets updated and not the line with the render error

smeubank avatar Aug 01 '22 13:08 smeubank

Opened a quick PR to improve this experience on the Sentry frontend - but we should take a general look at this when we get the time.

AbhiPrasad avatar Aug 02 '22 18:08 AbhiPrasad

This may have been fixed by the latest stack parsing fixes. Can someone get me the frames from the event to check?

timfish avatar Aug 04 '22 12:08 timfish

Yeah I’ll bump in sentry after we cut a release and confirm

AbhiPrasad avatar Aug 04 '22 13:08 AbhiPrasad

This seems to have been fixed - closing for now, but please re-open if the same problem occurs.

AbhiPrasad avatar Sep 15 '22 14:09 AbhiPrasad