sentry-javascript icon indicating copy to clipboard operation
sentry-javascript copied to clipboard

Bump `@types/express` to v5 for `@sentry/google-cloud-serverless`

Open caugner opened this issue 2 weeks ago • 4 comments

Is there an existing issue for this?

  • [x] I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
  • [x] I have reviewed the documentation https://docs.sentry.io/
  • [x] I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/google-cloud-serverless

SDK Version

10.29.0

Framework Version

No response

Link to Sentry event

No response

Reproduction Example/SDK Setup

https://github.com/mdn/dex/blob/44966e9b253b9c38a35f8bc7652609d0be049e3e/cloud-function/src/index.js#L7-L10

let handler = createHandler();

if (process.env["SENTRY_DSN"]) {
  Sentry.init();
  handler = Sentry.wrapHttpFunction(handler);
}

http("mdnHandler", handler);

Steps to Reproduce

  1. Bump @google-cloud/functions-framework from 4.0.0 to 4.0.1 (which bumps express from v4 to v5).

Expected Result

Expected types to match.

Actual Result

TypeScript complains about a type mismatch, because @google-cloud/functions-framework now expects express v5 signature, but @sentry/google-cloud-serverless depends on express v4.

Additional Context

No response

Priority

React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding +1 or me too, to help us triage it.

caugner avatar Dec 09 '25 09:12 caugner

JS-1273

linear[bot] avatar Dec 09 '25 09:12 linear[bot]

Thanks for the issue. Before addressing this I want to wait on their take of your raised issue.

As it seemed that this was already downgraded once: https://github.com/GoogleCloudPlatform/functions-framework-nodejs/pull/674

JPeer264 avatar Dec 09 '25 15:12 JPeer264

FWIW Back then only @types/express was bumped, but now https://github.com/GoogleCloudPlatform/functions-framework-nodejs/commit/148866281ef3886f4d1816da6cca705bd047156a bumped both express and @types/express.

caugner avatar Dec 09 '25 15:12 caugner

Indeed! I created a PR to mitigate the issue and be more flexible with the types. However, I will still wait 1 week ish to check on their state for the v5 upgrade

JPeer264 avatar Dec 10 '25 09:12 JPeer264

A PR closing this issue has just been released 🚀

This issue was referenced by PR #18452, which was included in the 10.31.0 release.

github-actions[bot] avatar Dec 16 '25 15:12 github-actions[bot]