fix(fetch): properly release fetch during long-lived stream handling
Hi,
I saw that the trackFetchStreamPerformance option was introduced in PR #13951 to bypass this issue, and Issue #13950 was closed as a result. However, this hasn't fully resolved the problem, so I attempted to address it in this PR.
Here is my modified test result after applying the changes:
@Lei-k we have not released #13951 yet, can you specify why this does not resolve the issue?
@chargome From what I understand, in #13951 only adds the trackFetchStreamPerformance option and sets it to false by default to bypass the issue. However, when this option is enabled, the problem still persists.
I saw some errors in the CI. I'll deal with them later
It seems that there are no further errors related to this PR. Can you please help confirm this, @chargome .
@chargome
Response was already in the code before, but now it's triggering a TS2304 error. Do you have any idea why this is happening?
It looks like only the TS2304 error and the file size check remain to be solved now.
@Lei-k not sure, but the same error is also crashing node-otel-sdk-node and node-otel-custom-sampler tests
@chargome
All tests have passed on my side. Please check, thanks!
Hi, @chargome
There’s one remaining bundle size check that failed due to the size limit. Could you assist me in adjusting the size, or do you have any suggestions for resolving this?
Closing this one for now, we might need to re-visit the entire fetch instrumentation for streams
Hi @chargome, Sorry, I just realized that my earlier comments were not actually submitted. I’ll sync with the latest branch and check the situation, and if needed, I’ll open a new PR to address it.