sentry-javascript icon indicating copy to clipboard operation
sentry-javascript copied to clipboard

feat(otel): Add support for non-tuple OTEL time.

Open onurtemizkan opened this issue 1 year ago • 1 comments

Adds support for cases where the time from OTEL is just a number in milliseconds instead of tuples.

Fixes: #12697 (Can't reproduce the issue but from the context of the report, this should resolve it)

onurtemizkan avatar Jun 28 '24 16:06 onurtemizkan

Yes, and I just realised that the PR is also incomplete, we need to detect if it's in milliseconds or seconds. In the issue it's in milliseconds.

onurtemizkan avatar Jun 28 '24 16:06 onurtemizkan

Can we instead just export spanTimeInputToSeconds from @sentry/core and use this? This already has all the different scenarios and should handle them correctly?

mydea avatar Jul 01 '24 07:07 mydea

Can we instead just export spanTimeInputToSeconds from @sentry/core and use this? This already has all the different scenarios and should handle them correctly?

Oh I wasn't aware of that! Updating the PR.

onurtemizkan avatar Jul 01 '24 08:07 onurtemizkan

size-limit report 📦

Path Size
@sentry/browser 22.22 KB (0%)
@sentry/browser (incl. Tracing) 33.38 KB (0%)
@sentry/browser (incl. Tracing, Replay) 69.16 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.49 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 73.22 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 85.82 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 87.68 KB (0%)
@sentry/browser (incl. metrics) 26.5 KB (0%)
@sentry/browser (incl. Feedback) 38.86 KB (0%)
@sentry/browser (incl. sendFeedback) 26.84 KB (0%)
@sentry/browser (incl. FeedbackAsync) 31.45 KB (0%)
@sentry/react 24.97 KB (0%)
@sentry/react (incl. Tracing) 36.43 KB (0%)
@sentry/vue 26.33 KB (0%)
@sentry/vue (incl. Tracing) 35.24 KB (0%)
@sentry/svelte 22.36 KB (0%)
CDN Bundle 23.42 KB (0%)
CDN Bundle (incl. Tracing) 35.12 KB (0%)
CDN Bundle (incl. Tracing, Replay) 69.25 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 74.45 KB (0%)
CDN Bundle - uncompressed 68.8 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 103.82 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 214.29 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 227 KB (0%)
@sentry/nextjs (client) 36.3 KB (0%)
@sentry/sveltekit (client) 34.02 KB (0%)
@sentry/node 130.61 KB (-0.01% 🔽)
@sentry/node - without tracing 91.62 KB (-0.03% 🔽)
@sentry/aws-serverless 116.8 KB (-0.02% 🔽)

github-actions[bot] avatar Jul 01 '24 10:07 github-actions[bot]