sentry-javascript icon indicating copy to clipboard operation
sentry-javascript copied to clipboard

feat: Add `thirdPartyErrorFilterIntegration`

Open timfish opened this issue 2 months ago • 2 comments

Described here: https://github.com/getsentry/sentry-javascript/pull/11718#issuecomment-2133432807

I didn't want to use the word integrity since for me at least, it reminds me of Subresource Integrity hashes and this is nothing like that. It's more of an id. For the metadata property I used bundle_key although it might be a better idea to use something that is less likely to clash with users existing metadata like __bundler_key.

My only minor concern is the behaviour strings which use what feels like a double negative logic... drop-if-not-matched. It made it quite hard to reason about what each one did and I got the logic wrong myself a couple of times!

type Behaviour =
  | 'drop-if-some-frames-not-matched'
  | 'drop-if-every-frames-not-matched'
  | 'apply-tag-if-some-frames-not-matched'
  | 'apply-tag-if-every-frames-not-matched';

timfish avatar May 28 '24 18:05 timfish