sentry-javascript icon indicating copy to clipboard operation
sentry-javascript copied to clipboard

feat(node): [v7] Support Node 22

Open AbhiPrasad opened this issue 1 year ago • 9 comments

tracking issue: https://github.com/getsentry/sentry-javascript/issues/11455

ABI is 126: https://github.com/electron/node-abi/blob/bd11f2da07c5da324e735e2de5bf6716ce97b11c/abi_registry.json#L95-L102

~Waiting for https://github.com/nodejs/node/pull/52505 to release!~

Added changelog entry for 7.113.0, will cut a release after this gets merged.

AbhiPrasad avatar Apr 23 '24 14:04 AbhiPrasad

I guess the node 22 docker containers have not been published yet 😅 - so we have to wait for that too

AbhiPrasad avatar Apr 24 '24 18:04 AbhiPrasad

You are just too fast @AbhiPrasad 🫣

JonasBa avatar Apr 24 '24 19:04 JonasBa

I'm taking matters into my own hands - https://github.com/nodejs/docker-node/pull/2071

AbhiPrasad avatar Apr 24 '24 19:04 AbhiPrasad

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 80.8 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 71.75 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 76 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 65.36 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 35.62 KB (0%)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 35.5 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.59 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.6 KB (0%)
@sentry/browser - Webpack (gzipped) 22.77 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 79 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 70.34 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 36.02 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 25.28 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 221.41 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 109.01 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 75.79 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 39.3 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 72.25 KB (0%)
@sentry/react - Webpack (gzipped) 22.81 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 90 KB (+0.01% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 54.13 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 17.34 KB (0%)

github-actions[bot] avatar Apr 25 '24 21:04 github-actions[bot]

blocked on https://github.com/docker-library/official-images/pull/16663

AbhiPrasad avatar Apr 25 '24 21:04 AbhiPrasad

Docker stuff is released https://hub.docker.com/_/node/tags

but late in day so we can only prob do v7 release on monday

AbhiPrasad avatar Apr 26 '24 18:04 AbhiPrasad

   Execute installation script
  Check if Python hostedtoolcache folder exist...
  Create Python 3.8.10 folder
  Copy Python binaries to hostedtoolcache folder
  Create additional symlinks (Required for the UsePythonVersion Azure Pipelines task and the setup-python GitHub Action)
  Upgrading pip...
  Looking in links: /tmp/tmp3o8h6q9d
  Requirement already satisfied: setuptools in /opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages (56.0.0)
  Requirement already satisfied: pip in /opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages (21.1.1)
  Error: Usage:   
    /opt/hostedtoolcache/Python/3.8.10/x64/bin/python -m pip install [options] <requirement specifier> [package-index-options] ...
    /opt/hostedtoolcache/Python/3.8.10/x64/bin/python -m pip install [options] -r <requirements file> [package-index-options] ...
    /opt/hostedtoolcache/Python/3.8.10/x64/bin/python -m pip install [options] [-e] <vcs project url> ...
    /opt/hostedtoolcache/Python/3.8.10/x64/bin/python -m pip install [options] [-e] <local project path> ...
    /opt/hostedtoolcache/Python/3.8.10/x64/bin/python -m pip install [options] <archive url/path> ...
  
  no such option: --root-user-action
  Error: The process '/usr/bin/bash' failed with exit code 2
  ##[debug]Node Action run completed with exit code 1
  ##[debug]Finishing: Setup python

bruh

AbhiPrasad avatar Apr 26 '24 21:04 AbhiPrasad

Oh wait this is happening on master as well! https://github.com/getsentry/sentry-javascript/actions/runs/8853059168/job/24313364936

AbhiPrasad avatar Apr 26 '24 21:04 AbhiPrasad

Here's the bug https://github.com/actions/setup-python/issues/853

AbhiPrasad avatar Apr 26 '24 21:04 AbhiPrasad

Just need to fix a bug with win22, I'm hoping its an issue with the minmax macro

JonasBa avatar May 01 '24 18:05 JonasBa