sentry-javascript icon indicating copy to clipboard operation
sentry-javascript copied to clipboard
verified publisher icon getsentry

fix(angular): run tracing stuff outside Angular

Open arturovt opened this issue 1 year ago • 3 comments

This commit updates all tracing functionality to run outside the Angular zone. Before this change, it hindered server-side rendering and hydration, causing instability in the app. The app achieves stability when there are no micro/macro tasks running. As a result, the HTML can now be serialized and sent to the client.

arturovt avatar Apr 23 '24 10:04 arturovt

Yeah, I was waiting for other PR to be merged.

(could never thought it's called biome :joy: )

arturovt avatar Apr 25 '24 09:04 arturovt

could never thought it's called biome 😂

yeah, it's because we use biome instead of prettier (for now; we'll probably revert in a couple of weeks) 😅

Lms24 avatar Apr 25 '24 14:04 Lms24

heads-up: I re-created your PR (https://github.com/getsentry/sentry-javascript/pull/11794) just to run our e2e test for Angular. Unfortunately our e2e tests don't run on external contributor PRs. Once the test passes, I'll merge your PR.

Lms24 avatar Apr 25 '24 15:04 Lms24