sentry-javascript icon indicating copy to clipboard operation
sentry-javascript copied to clipboard

feat(feedback): Auto start buffering replays if enabled and flush on form open

Open billyvg opened this issue 1 year ago • 1 comments

  • By default (can be disabled), if replay integration exists, start buffering
  • Flush replay when the feedback form is first opened instead of at submit time

We are making this change because we have noticed a lot of feedback replays only consist of the user submitting the feedback and not what they did prior to submitting feedback. This may result in false positives if users open but do not submit feedback, but this should make replays from feedback more useful.

billyvg avatar Feb 08 '24 00:02 billyvg

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.35 KB (+0.25% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.57 KB (+0.22% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.51 KB (+0.23% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.12 KB (+0.24% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.8 KB (+0.46% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 32.8 KB (+0.46% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.01 KB (+0.66% 🔺)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.01 KB (+0.66% 🔺)
@sentry/browser - Webpack (gzipped) 22.25 KB (+0.72% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.79 KB (+0.28% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.42 KB (+0.24% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.26 KB (+0.51% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.76 KB (+0.72% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 211.01 KB (+0.13% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 99.74 KB (+0.29% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 74 KB (+0.49% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.32 KB (+0.43% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 68.84 KB (+0.2% 🔺)
@sentry/react - Webpack (gzipped) 22.28 KB (+0.72% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.32 KB (+0.16% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 49.66 KB (+0.29% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.09 KB (+0.31% 🔺)

github-actions[bot] avatar Feb 08 '24 01:02 github-actions[bot]

Have been digging around the code and it looks like this feature has disappeared in v8, despite it still being documented https://docs.sentry.io/platforms/javascript/guides/react/user-feedback/#session-replay

@billyvg

philcaonz avatar Jul 27 '24 12:07 philcaonz

Have been digging around the code and it looks like this feature has disappeared in v8, despite it still being documented docs.sentry.io/platforms/javascript/guides/react/user-feedback#session-replay

@billyvg

@philcaonz It's here: https://github.com/getsentry/sentry-javascript/blob/f61e729423cca0f36f8971021ac9b2457ba55c85/packages/replay-internal/src/coreHandlers/handleGlobalEvent.ts#L40-L48

billyvg avatar Jul 29 '24 20:07 billyvg