sentry-javascript icon indicating copy to clipboard operation
sentry-javascript copied to clipboard
verified publisher icon getsentry

ref(sveltekit): Explicitly set `peerDependencies` for `svelte`

Open Lms24 opened this issue 1 year ago • 1 comments

This PR explicitly sets Svelte 3 and 4 as peer dependencies for SvelteKit.

We already require these versions in @sentry/svelte but this peer dep conflict goes unnoticed when installing @sentry/sveltekit. This should make it more clear on installation that we don't support Svelte 5 yet (Svelte 5 is not yet stable).

Fwiw, we do the same in NextJS with React (I assume for the same reasons)

ref #10275 ref #10318

Lms24 avatar Jan 24 '24 13:01 Lms24

how does this cause the e2e test fails 🙈

Lms24 avatar Jan 24 '24 15:01 Lms24

Not sure what's happening here but it looks like vite treats dependencies differently if they're registered as peerDependencies 🤔 I'm gonna close this for now as I think it's ok not to mention svelte explicitly in this SDK.

Lms24 avatar May 03 '24 11:05 Lms24