sentry-java icon indicating copy to clipboard operation
sentry-java copied to clipboard
verified publisher icon getsentry

[SR] Support orientation change in multi-window mode

Open romtsn opened this issue 1 year ago • 4 comments

Description

Currently we stop+restart capturing when we encounter orientation change, but it seems that in multi-window mode the window is not being removed + added. So we have to change this to pause+resume capturing and refresh the recorder config

romtsn avatar Oct 16 '24 08:10 romtsn

can i do this? @romtsn

thisames avatar Oct 25 '24 15:10 thisames

@thisames feel free to if you know the key pieces for this!

romtsn avatar Nov 04 '24 09:11 romtsn

@thisames feel free to if you know the key pieces for this!

I dont know if I understand wrong, but after of debugger, I confess that stay a little confused. cause in my tests the multi-window mode window are being removed + added with success in change orientation.

https://github.com/user-attachments/assets/5530aa74-4965-4400-9a9d-a5894a1a9de1

thisames avatar Dec 02 '24 19:12 thisames

hm so it works on your end? @thisames

we'll have a look!

buenaflor avatar Dec 05 '24 10:12 buenaflor

I think this works now with the latest changes from https://github.com/getsentry/sentry-java/pull/4354 as we don't stop the recorder anymore

romtsn avatar Jul 07 '25 09:07 romtsn