sentry-java icon indicating copy to clipboard operation
sentry-java copied to clipboard

Add support for setting sentry-native handler_strategy

Open markushi opened this issue 1 year ago • 4 comments

:scroll: Description

Bump sentry-native, add options to SentryAndroidOptions, extend sentry-native init code.

:bulb: Motivation and Context

https://github.com/getsentry/sentry-native/issues/1026

:green_heart: How did you test it?

:pencil: Checklist

  • [ ] I reviewed the submitted code.
  • [ ] I added tests to verify the changes.
  • [ ] No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • [ ] I updated the docs if needed.
  • [ ] Review from the native team if needed.
  • [ ] No breaking change or entry added to the changelog.
  • [ ] No breaking change for hybrid SDKs or communicated to hybrid SDKs.

:crystal_ball: Next steps

markushi avatar Aug 30 '24 09:08 markushi

Messages
:book: Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by :no_entry_sign: dangerJS against 18242881aa08c2b828e1d3749494a558cd498fff

github-actions[bot] avatar Aug 30 '24 09:08 github-actions[bot]

Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 450.35 ms 454.31 ms 3.95 ms
Size 1.70 MiB 2.36 MiB 672.11 KiB

Previous results on branch: feat/sentry-dotnet-inproc-handler-strategy

Startup times

Revision Plain With Sentry Diff
cbda9bd2680de5b2582551bc88d1c2a1a9a0901a 324.12 ms 375.45 ms 51.33 ms

App size

Revision Plain With Sentry Diff
cbda9bd2680de5b2582551bc88d1c2a1a9a0901a 1.70 MiB 2.36 MiB 672.11 KiB

github-actions[bot] avatar Aug 30 '24 10:08 github-actions[bot]

@bitsandfoxes do you know if the underlying .NET issue is solved by this? Or in other words: Should we move forward with this and get it merged?

markushi avatar Sep 26 '24 13:09 markushi

@bitsandfoxes do you know if the underlying .NET issue is solved by this? Or in other words: Should we move forward with this and get it merged?

AFAIK this will resolve https://github.com/dotnet/android/issues/9055 I could reproduce this locally We should verify this works as intended.

bitsandfoxes avatar Oct 09 '24 13:10 bitsandfoxes

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

getsantry[bot] avatar Oct 31 '24 07:10 getsantry[bot]

@bitsandfoxes we eventually still want to have this merged, right?

markushi avatar Nov 01 '24 09:11 markushi

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

getsantry[bot] avatar Nov 23 '24 08:11 getsantry[bot]