removed user segment

[stefanosiano]

:scroll: Description

:bulb: Motivation and Context

Closes https://github.com/getsentry/sentry-java/issues/3497

:green_heart: How did you test it?

:pencil: Checklist

• [ ] I reviewed the submitted code.
• [ ] I added tests to verify the changes.
• [ ] No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
• [ ] I updated the docs if needed.
• [ ] Review from the native team if needed.
• [ ] No breaking change or entry added to the changelog.
• [ ] No breaking change for hybrid SDKs or communicated to hybrid SDKs.

:crystal_ball: Next steps

[adinauer]

@markushi I'm confused, where's the problems with merging?

[markushi]

@markushi I'm confused, where's the problems with merging?

We have two PRs:

1. https://github.com/getsentry/sentry-java/pull/3511 adds the deprecate annotation
2. This one, completely removing user.segment

But since 2. isn't built on top of 1., all the changes in this PR will cause a merge conflict once 1. is merged into main and 8.x.x

[stefanosiano]

@markushi I'm confused, where's the problems with merging?

We have two PRs:

1. deprecated User.segment #3511 adds the deprecate annotation
2. This one, completely removing user.segment

But since 2. isn't built on top of 1., all the changes in this PR will cause a merge conflict once 1. is merged into main and 8.x.x

I see what you mean. To me it's fine to wait a while before merging it. We can wait until v8 is "stable" and we merge main back in v8, as it's not an urgent change

[adinauer]

Should be fine to merge, just watch out when merging main into 8.x.x.

[stefanosiano]

i updated this PR after merging master into v8 branch. Would you take another look now?

[github-actions[bot]]

Performance metrics :rocket:

	Plain	With Sentry	Diff
Startup time	366.24 ms	457.38 ms	91.14 ms
Size	1.70 MiB	2.29 MiB	599.21 KiB

Baseline results on branch: 8.x.x

Startup times

Revision	Plain	With Sentry	Diff
57732e89c9bdcfa0da2e390fe5124b9867cd8db2	435.66 ms	510.50 ms	74.84 ms
a0f7731850f80c8db20ef17aca53db37fe0042ff	357.02 ms	433.40 ms	76.38 ms
41e496a847e15a0fabd722246283aa5e855ae91e	408.90 ms	491.32 ms	82.42 ms
a59fca29342f9ee762aefa59d4928457427b81d3	560.08 ms	658.80 ms	98.71 ms

App size

Revision	Plain	With Sentry	Diff
57732e89c9bdcfa0da2e390fe5124b9867cd8db2	1.70 MiB	2.29 MiB	599.77 KiB
a0f7731850f80c8db20ef17aca53db37fe0042ff	1.70 MiB	2.29 MiB	599.77 KiB
41e496a847e15a0fabd722246283aa5e855ae91e	1.70 MiB	2.29 MiB	599.77 KiB
a59fca29342f9ee762aefa59d4928457427b81d3	1.70 MiB	2.29 MiB	599.77 KiB