sentry-java icon indicating copy to clipboard operation
sentry-java copied to clipboard

Hubs/Scopes Merge 42d - Close previous scopes before binding a new global client

Open adinauer opened this issue 9 months ago • 2 comments

:scroll: Description

:bulb: Motivation and Context

When calling close on the previous scopes after a new client has already been bound to the global scope, the new client is closed and Sentry does not capture events anymore.

:green_heart: How did you test it?

:pencil: Checklist

  • [ ] I reviewed the submitted code.
  • [ ] I added tests to verify the changes.
  • [ ] No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • [ ] I updated the docs if needed.
  • [ ] Review from the native team if needed.
  • [ ] No breaking change or entry added to the changelog.
  • [ ] No breaking change for hybrid SDKs or communicated to hybrid SDKs.

:crystal_ball: Next steps

adinauer avatar May 02 '24 11:05 adinauer

Fails
:no_entry_sign: Please consider adding a changelog entry for the next release.
Messages
:book: Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Hubs/Scopes Merge 42d - Close previous scopes before binding a new global client ([#3404](https://github.com/getsentry/sentry-java/pull/3404))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by :no_entry_sign: dangerJS against dee22033efd5435ca0a48024110e416fa46a9e27

github-actions[bot] avatar May 02 '24 11:05 github-actions[bot]

Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 580.90 ms 698.31 ms 117.41 ms
Size 1.70 MiB 2.28 MiB 595.65 KiB

Previous results on branch: feat/hsm-42d-close-bind-client-ordering

Startup times

Revision Plain With Sentry Diff
dd4548a5147cb0960c43472369cc20e978b9d102 337.77 ms 436.57 ms 98.80 ms

App size

Revision Plain With Sentry Diff
dd4548a5147cb0960c43472369cc20e978b9d102 1.70 MiB 2.28 MiB 595.70 KiB

github-actions[bot] avatar May 02 '24 12:05 github-actions[bot]