sentry-java icon indicating copy to clipboard operation
sentry-java copied to clipboard

Report suppressed exceptions as exception group

Open adinauer opened this issue 1 year ago • 2 comments

#skip-changelog

:scroll: Description

Report exceptions returned by Throwable.getSuppressed() to Sentry as exception groups. They show up like this:

Screenshot 2024-04-29 at 16 42 41

Links can be clicked and take you to the exception on the same page.

:bulb: Motivation and Context

Fixes #542

:green_heart: How did you test it?

:pencil: Checklist

  • [ ] I reviewed the submitted code.
  • [ ] I added tests to verify the changes.
  • [ ] No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • [ ] I updated the docs if needed.
  • [ ] Review from the native team if needed.
  • [ ] No breaking change or entry added to the changelog.
  • [ ] No breaking change for hybrid SDKs or communicated to hybrid SDKs.

:crystal_ball: Next steps

adinauer avatar Apr 29 '24 14:04 adinauer

Fails
:no_entry_sign: Please consider adding a changelog entry for the next release.
Messages
:book: Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Report suppressed exceptions as exception group ([#3396](https://github.com/getsentry/sentry-java/pull/3396))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by :no_entry_sign: dangerJS against 18ad266a112adbc2f792547b3372de95f8871881

github-actions[bot] avatar Apr 29 '24 14:04 github-actions[bot]

Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 449.88 ms 525.45 ms 75.57 ms
Size 1.70 MiB 2.28 MiB 595.99 KiB

Previous results on branch: feat/hsm-42c-suppressed-exceptions

Startup times

Revision Plain With Sentry Diff
0a61517241020da4a08b335084b0df2096cc9206 394.71 ms 454.42 ms 59.71 ms
37d1e27c51e306d034b0686c70344c1531edef87 379.49 ms 423.67 ms 44.18 ms
99b5ed4607a3fcc26ae19a93953c9909ea6d6dfc 386.04 ms 460.83 ms 74.79 ms
25e177134bb732818c9ca306f013f8d7adbfe14e 383.98 ms 459.50 ms 75.52 ms
1c2fbfe421b94d51ab387f8ea4c5a0abd66cdb6c 403.73 ms 463.84 ms 60.11 ms
a23c14591e38951c4458c109ace2a77b0e939a5c 396.22 ms 458.98 ms 62.76 ms
702ae01f0d0771816fea5af4d8f471c0a90de447 403.63 ms 476.15 ms 72.51 ms
c822b54b1a07ceb74c468ae442e770e47edb28cc 431.59 ms 549.47 ms 117.88 ms
0c124b6d29b02a0f8be2371169a4b81691e8aef0 382.98 ms 458.90 ms 75.92 ms

App size

Revision Plain With Sentry Diff
0a61517241020da4a08b335084b0df2096cc9206 1.70 MiB 2.28 MiB 595.98 KiB
37d1e27c51e306d034b0686c70344c1531edef87 1.70 MiB 2.28 MiB 595.95 KiB
99b5ed4607a3fcc26ae19a93953c9909ea6d6dfc 1.70 MiB 2.28 MiB 595.99 KiB
25e177134bb732818c9ca306f013f8d7adbfe14e 1.70 MiB 2.28 MiB 595.98 KiB
1c2fbfe421b94d51ab387f8ea4c5a0abd66cdb6c 1.70 MiB 2.28 MiB 595.99 KiB
a23c14591e38951c4458c109ace2a77b0e939a5c 1.70 MiB 2.28 MiB 595.97 KiB
702ae01f0d0771816fea5af4d8f471c0a90de447 1.70 MiB 2.28 MiB 595.97 KiB
c822b54b1a07ceb74c468ae442e770e47edb28cc 1.70 MiB 2.28 MiB 595.97 KiB
0c124b6d29b02a0f8be2371169a4b81691e8aef0 1.70 MiB 2.28 MiB 595.97 KiB

github-actions[bot] avatar Apr 29 '24 14:04 github-actions[bot]

Do we have an ETA for when it can be merged and released?

rodolfoBee avatar May 13 '24 09:05 rodolfoBee

@rodolfoBee since we're merging this into 8.x it might be a couple weeks until we release an early alpha of 8.x as we want to include some changes around Performance powered by OTel.

adinauer avatar May 13 '24 09:05 adinauer

@rodolfoBee we just discussed this internally and we're planning to merge this sooner and do an alpha release without Performance powered by OpenTelemetry. Just need to prepare some things for the release.

adinauer avatar May 13 '24 11:05 adinauer