sentry-java
sentry-java copied to clipboard
getsentry
Add Jetpack Compose UI tests to test matrix
Description
Add Jetpack Compose UI tests to test matrix, so we can ensure newer version of JPC still work, e.g. see a recent issue here: https://github.com/getsentry/sentry-java/pull/3010
Another problem due to Sentry's reliance on 3rd part ABI.
These two issues have cost us several days of developer time over a couple of weeks. At this rate, this Sentry magic is doing us more harm than good.
It's reasonable to assume that 3rd party code will continue to be developed and refactored. So there will be more such cases where Sentry integrations that rely on reflection or bytecode manipulation will continue to break. These issues are very hard to reason about, as most of the time they appear when the 3rd party lib is updated (not Sentry).
I would really like to see Sentry have full instrumentation tests for integrations with the latest stable 3rd party libraries :pray:
Maybe something like dependabot/renovate could automatically bump dependencies to latest stable/RC* versions and run instrumentation tests.
@audkar thanks for your feedback, and I agree we should be doing a better job wrt testing against new versions of our dependencies. I just want to point out that this is only the 2nd issue with Room within the past 2 years, and it's only happening when you actually flip the flag which is turned-off by default, so it's not that bad, but we'll definitely reserve some time to look into forwards-compatibility 👍
this is only the 2nd issue with Room within the past 2 years
Yes. Sorry for the poor wording. I didn't mean to imply that this was a very common problem in the past. It's more that this has happened, is happening, and will happen in the feature. This problem is inevitable. But some sort of additional mitigation could be done on the Sentry side. I am happy that we are at the same page :bow:
Problem not only related to Room, e.g. I think Compose integrations is still not working (couldn't spend more time on Senty, will check again later). As https://github.com/getsentry/sentry-java/pull/3010 was only fixed for manually added SentryTag modifier. But there was no fix for sentry-kotlin-compiler-plugin.