sentry-java icon indicating copy to clipboard operation
sentry-java copied to clipboard

Add db attributes to span data for Java backend spans

Open romtsn opened this issue 1 year ago • 2 comments

Description

Follow-up from #2893

We're going to matching the otel db conventions. Either one of server.address or server.socket.address is required. If server.address is set, then server.port should be set. If server.port is different than server.socket.port, than server.socket.port should also be set. In addition, db.name should be set if possible. db.system should match the list in OpenTelemetry's well known conventions.

Attribute Type Description Examples Requirement Level
server.address string Name of the database host. example.com Conditionally Required: See alternative attributes below.
server.port int Logical server port number 80; 8080; 443 Conditionally Required: [1]
server.socket.address string Physical server IP address or Unix socket address. 10.5.3.2 See below
server.socket.port int Physical server port. 16456 Recommended: If different than server.port.

These values should be set on span.data.

romtsn avatar Sep 12 '23 08:09 romtsn

@AbhiPrasad are any of these remaining attributes required soon / is there any date you'd like to have them by? Otherwise I'll just put this in the backlog to do at some point but without urgency.

adinauer avatar Sep 12 '23 08:09 adinauer

No urgency on these, they can be backlogged for now.

AbhiPrasad avatar Sep 12 '23 13:09 AbhiPrasad