sentry-java icon indicating copy to clipboard operation
sentry-java copied to clipboard

Add ignoreTransactions and ignoreErrors

Open smeubank opened this issue 2 years ago • 7 comments

Background:

To further simplfiy ignoring certain events from being sent to sentry, it is also suggested to provide ignoreTransactions and ignoreErrors

More info here develop docs updated: https://develop.sentry.dev/sdk/features/#event-sampling

  • [ ] ignoreErrors
  • [ ] ignoreTransactions
  • [ ] SDK docs

smeubank avatar Apr 17 '23 12:04 smeubank

@romtsn or @adinauer is it relevant to track this with another ticket for android?

smeubank avatar Apr 17 '23 12:04 smeubank

We already have ignoreExceptionsForType, is this supposed to be ignoreErrors?

It's fine to track this for android here as well, imo.

romtsn avatar Apr 17 '23 21:04 romtsn

Keep client reports in mind: https://github.com/getsentry/team-webplatform-meta/issues/46#issuecomment-1523501834

markushi avatar Apr 26 '23 14:04 markushi

@smeubank Can you provide the final decision on this issue? Also, is there a doc we can refer to?

stefanosiano avatar Jul 26 '23 14:07 stefanosiano

We already have ignoreExceptionsForType, is this supposed to be ignoreErrors?

if this is the same as ignoreErrors in other platforms then it will suffice, would be ideal if the naming was more similar for simplicity of understanding across platforms. Seems it may behave slightly different to the other options in other SDKs though

ignoreTransactions is still needed in java and android according to docs

smeubank avatar Jul 26 '23 14:07 smeubank

Java behavior: only applies to specific class type, but not child classes. - as opposed to .net and Dart.

markushi avatar Aug 09 '23 14:08 markushi

Let's just focus on adding ignoreTransactions within this ticket.

markushi avatar Aug 09 '23 14:08 markushi