sentry-java icon indicating copy to clipboard operation
sentry-java copied to clipboard

New sample with min api level

Open marandaneto opened this issue 3 years ago • 2 comments

:scroll: Description

:bulb: Motivation and Context

Fixes https://github.com/getsentry/sentry-java/issues/1403

:green_heart: How did you test it?

:pencil: Checklist

  • [ ] I reviewed the submitted code
  • [ ] I added tests to verify the changes
  • [ ] I updated the docs if needed
  • [ ] No breaking changes

:crystal_ball: Next steps

marandaneto avatar Jun 20 '22 19:06 marandaneto

Fails
:no_entry_sign: Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- New sample with min api level ([#2117](https://github.com/getsentry/sentry-java/pull/2117))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by :no_entry_sign: dangerJS against f050a46f0fe621cece41a45a6ad937e36c0ac9f2

github-actions[bot] avatar Jun 20 '22 19:06 github-actions[bot]

Codecov Report

Merging #2117 (f050a46) into main (ba9dda7) will decrease coverage by 0.06%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2117      +/-   ##
============================================
- Coverage     80.92%   80.85%   -0.07%     
+ Complexity     3253     2918     -335     
============================================
  Files           231      176      -55     
  Lines         11951    10545    -1406     
  Branches       1586     1433     -153     
============================================
- Hits           9671     8526    -1145     
+ Misses         1700     1509     -191     
+ Partials        580      510      -70     
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/SentryClient.java 87.50% <ø> (ø)
sentry/src/main/java/io/sentry/TracesSampler.java 100.00% <ø> (ø)
sentry/src/main/java/io/sentry/Baggage.java 89.28% <100.00%> (+0.12%) :arrow_up:
...ring/tracing/SpringMvcTransactionNameProvider.java
.../java/io/sentry/graphql/SentryInstrumentation.java
...java/io/sentry/spring/webflux/SentryWebFilter.java
.../io/sentry/spring/tracing/SentryTracingFilter.java
...y/spring/HttpServletRequestSentryUserProvider.java
...o/sentry/spring/webflux/SentryRequestResolver.java
...main/java/io/sentry/spring/SentryHubRegistrar.java
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ba9dda7...f050a46. Read the comment docs.

codecov-commenter avatar Jun 21 '22 08:06 codecov-commenter

👋

bruno-garcia avatar Jun 01 '23 13:06 bruno-garcia

Outdated, a new PR would make more sense.

marandaneto avatar Jun 01 '23 13:06 marandaneto

sry, never got to it. Does it still make sense to have a min-api-level sample or should we rather have an automated test running against the app with the min-api-level? I'm afraid I will never use this sample for my local testing

romtsn avatar Jun 01 '23 13:06 romtsn