sentry-java icon indicating copy to clipboard operation
sentry-java copied to clipboard

Mobile Vitals for UI events transactions

Open romtsn opened this issue 3 years ago • 3 comments

Report slow and frozen frames for recently added UI events transactions on iOS and Android.

romtsn avatar May 04 '22 12:05 romtsn

As I understood, this is already done on iOS for every transaction, since they don't need the instance of the view such as activity.

marandaneto avatar May 12 '22 10:05 marandaneto

Moving to the sentry-java repo since iOS already has this.

bruno-garcia avatar Jun 15 '22 14:06 bruno-garcia

As I understood, this is already done on iOS for every transaction, since they don't need the instance of the view such as activity.

Yes, indeed.

philipphofmann avatar Jun 17 '22 06:06 philipphofmann

Would probably need to replace ActivityFramesTracker with something based on choreographer.postFrameCallback(frameCallback) similar to what is done here https://github.com/getsentry/sentry-java/blob/730095684bb732a0a7d0cc88d3c3b913a08d7cfe/sentry-android-integration-tests/sentry-uitest-android-benchmark/src/androidTest/java/io/sentry/uitest/android/benchmark/util/BenchmarkOperation.kt#L142-L166

This would then also be helpful for FPS Mobile Vitals.

adinauer avatar Sep 30 '22 17:09 adinauer

This is already done for Profiling, as frame metrics are already collected on a frame by frame level. It probably makes sense to refactor the existing ActivityFramesTracker and make it's collected data available to both Profiling and Transactions.

markushi avatar Feb 15 '23 15:02 markushi

It could make sense to re-use the frame-by-frame profiling collector in case there isn't too much of an overhead. (SentryFramesMetricCollector)

markushi avatar Feb 15 '23 15:02 markushi

this is superseded by mobile starfish and will be tackled by the mobile interfactions module

romtsn avatar Mar 06 '24 14:03 romtsn