sentry-java icon indicating copy to clipboard operation
sentry-java copied to clipboard

Move Android options from `SentryOptions` to `SentryAndroidOptions`

Open marandaneto opened this issue 3 years ago • 2 comments

Description

enableNdk is one example, there are likely more.

marandaneto avatar Apr 19 '22 07:04 marandaneto

probably idleTimeout can also be moved to AndroidOptions since it's kind of a UI-relevant thing - backend probably won't ever need it

romtsn avatar Jun 24 '22 07:06 romtsn

probably idleTimeout can also be moved to AndroidOptions since it's kind of a UI-relevant thing - backend probably won't ever need it

Java desktop apps would use it, so I'd rather keep it.

marandaneto avatar Jun 24 '22 08:06 marandaneto

I had a closer look, there are some options which are related to UI (enableTimeToFullDisplayTracing, mainThreadChecker, fullyDisplayedReporter, ...) but those could be relevant for Desktop as well.

There's also proguardUuid, but ProGuard could be used on Desktop/Backend as well.

On the other hand the screenshot/viewhierarchy options are in SentryAndroidOptions, I'm wondering if it makes sense to move them to SentryOptions 🤔

markushi avatar Jun 21 '23 12:06 markushi

@markushi variables that are in the SentryAndroidOptions can be moved to SentryOptions whenever needed, without a breaking change. I'd rather focus on the variables that are in SentryOptions but are Android only, so it's less confusing for e.g. Java BE/FE people.

marandaneto avatar Jun 22 '23 07:06 marandaneto